Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for id attribute in a tags in markdown #2929

Conversation

maudetes
Copy link
Contributor

@maudetes maudetes commented Nov 21, 2023

This would allow for adding anchors in markdown contents.
Exemple :

# Cookie <a id="cookie"></a>

We want a section full of cookies (the edible ones).

We could then use the anchor as /posts/my-post-about-food/#cookie

Notes

I haven't found any other simpler way to add anchors with our markdown parser.
I haven't checked yet for security warning on adding these.

@maudetes
Copy link
Contributor Author

Well, it is a complicated topic with security issues : markdown-it/markdown-it#28.
Using name would be safer but not cleared of all risks?
The need for anchors may not be worth the trouble.

@maudetes maudetes closed this Nov 30, 2023
@maudetes maudetes deleted the feat/allow-for-id-attributes-in-a-tags-in-markdown branch November 30, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant