This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Python Requirements Update #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 86.54% 86.11% -0.43%
==========================================
Files 11 11
Lines 951 951
Branches 156 156
==========================================
- Hits 823 819 -4
- Misses 85 88 +3
- Partials 43 44 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
UsamaSadiq
approved these changes
Aug 24, 2021
| @@ -195,7 +195,7 @@ def customize_ruleset(self, custom_ruleset_file=None): | |||
| if not custom_file: | |||
| return | |||
|
|
|||
| with open(custom_file) as additional_rules: | |||
| with open(custom_file, encoding="utf8") as additional_rules: | |||
There was a problem hiding this comment.
pylint version 2.10.0 deprecated the use of open() without explicitly specifying any encoding. See pylint-dev/pylint#3826 for details.
mzulqarnain1
approved these changes
Aug 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python requirements update.Please review the changelogs for the upgraded packages.