Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOM-2775: Pin pluggy version to resolve the make upgrade failure #107

Merged
merged 1 commit into from Sep 2, 2021
Merged

BOM-2775: Pin pluggy version to resolve the make upgrade failure #107

merged 1 commit into from Sep 2, 2021
+287 −268

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Sep 1, 2021 •
edited

Issue: BOM-2775

Description

  • Make upgrade job failed due to the pluggy pacakge conflict between diff-cover(requires pluggy<0.13.0) and pytest(requires pluggy>=0.13.1,<2.0.0). See build details: https://github.com/edx/edx-rbac/actions/runs/1192520039.
  • Used the same version of diff-cover==4.0.0 which is being used currently in edx-platform to avoid the pluggy package conflict.
  • Disabled the following pylint warnings introduced in new versions (these are disabled in almost all of the edx repos already):
  • duplicate-code
  • invalid-name
  • no-absolute-import
  • no-self-use
  • too-few-public-methods
  • too-many-public-methods
  • unspecified-encoding
  • use-maxsplit-arg

UsamaSadiq
UsamaSadiq commented Sep 1, 2021
View reviewed changes
requirements/constraints.txt

# stevedore 2.0.0 doesn't install on python 3.5 (circa 2020-06-10)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constraints are not needed any more because the repo has been upgraded to use Python3.8.

@UsamaSadiq UsamaSadiq marked this pull request as ready for review September 1, 2021 07:09
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/bom-2775-add-common-constraints branch 2 times, most recently from 1e0bd1a to 3c2174b Compare September 1, 2021 07:16
UsamaSadiq
UsamaSadiq commented Sep 1, 2021
View reviewed changes
setup.py Outdated Show resolved Hide resolved
UsamaSadiq
UsamaSadiq commented Sep 1, 2021
View reviewed changes
tox.ini
@@ -61,7 +61,7 @@ commands =
pylint --py3k edx_rbac tests test_utils manage.py setup.py
pycodestyle edx_rbac tests manage.py setup.py
pydocstyle edx_rbac tests manage.py setup.py
isort --check-only --diff --recursive tests test_utils edx_rbac manage.py setup.py test_settings.py
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isort latest version has deprecated the --recursive flag.

@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/bom-2775-add-common-constraints branch from 3c2174b to b4ecab1 Compare September 2, 2021 10:15
@UsamaSadiq UsamaSadiq changed the title BOM-2775: Add common constraints to resolve the make upgrade failure BOM-2775: Pin pluggy vrsion to resolve the make upgrade failure Sep 2, 2021
@UsamaSadiq UsamaSadiq changed the title BOM-2775: Pin pluggy vrsion to resolve the make upgrade failure BOM-2775: Pin pluggy version to resolve the make upgrade failure Sep 2, 2021
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/bom-2775-add-common-constraints branch 3 times, most recently from d167d80 to e2b014a Compare September 2, 2021 11:33
@awais786 awais786 closed this Sep 2, 2021
@UsamaSadiq UsamaSadiq reopened this Sep 2, 2021
@UsamaSadiq
fix: Add common constraints to resolve the make upgrade failure
e5ad7a4 
Make upgrade job failed due to conflict of pluggy requirement between diff-cover(pluggy<1.0.0a1) and pytest(pluggy<2.0.0)
So pinned the pluggy version<1.0.0a1 to resolve this conflict for now.
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/bom-2775-add-common-constraints branch from e2b014a to e5ad7a4 Compare September 2, 2021 15:26
@UsamaSadiq UsamaSadiq merged commit 8add42f into master Sep 2, 2021
@UsamaSadiq UsamaSadiq deleted the usamasadiq/bom-2775-add-common-constraints branch September 2, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awais786 awais786 awais786 approved these changes

@mzulqarnain1 mzulqarnain1 mzulqarnain1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@UsamaSadiq @awais786 @mzulqarnain1