Python Requirements Update #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 77.29% 77.29%
=======================================
Files 21 21
Lines 1026 1026
=======================================
Hits 793 793
Misses 233 233
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
UsamaSadiq
reviewed
Aug 24, 2021
| @@ -14,7 +14,7 @@ def get_version(*file_paths): | |||
| Extract the version string from the file at the given relative path fragments. | |||
| """ | |||
| filename = os.path.join(os.path.dirname(__file__), *file_paths) | |||
| version_file = open(filename).read() # pylint: disable=consider-using-with | |||
| version_file = open(filename, encoding="utf8").read() # pylint: disable=consider-using-with | |||
There was a problem hiding this comment.
pylint version 2.10.0 deprecated the use of open() without explicitly specifying any encoding. See pylint-dev/pylint#3826 for details.
UsamaSadiq
approved these changes
Aug 24, 2021
|
@timmc-edx I'll create another PR to add six in the requirements for now to resolve the failing Jenkins job issue. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python requirements update.Please review the changelogs for the upgraded packages.