Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #803

Merged
merged 8 commits into from Jul 18, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 9, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17, along with react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated edx packages @edx/frontend-platform, @edx/frontend-component-header, @edx/frontend-component-footer

@Mashal-m Mashal-m force-pushed the bilalqamar95/react-upgrade-to-v17 branch from 14bc759 to cded64c Compare June 13, 2023 14:56
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (80d0c44) 46.13% compared to head (acf438d) 46.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files         121      121           
  Lines        2525     2525           
  Branches      666      666           
=======================================
  Hits         1165     1165           
  Misses       1284     1284           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m Mashal-m marked this pull request as ready for review July 5, 2023 09:45
@abdullahwaheed abdullahwaheed merged commit d66dcec into master Jul 18, 2023
8 checks passed
@abdullahwaheed abdullahwaheed deleted the bilalqamar95/react-upgrade-to-v17 branch July 18, 2023 07:28
snglth pushed a commit to Abstract-Tech/community-theme-account that referenced this pull request Jan 9, 2024
* feat: update react & react-dom to v17

* feat: update react & react-dom to v17

* build: update lock file

* refactor: updated edx packages

* refactor: removed unnecessary lint disable

---------

Co-authored-by: mashal-m <mashal.malik@arbisoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants