Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #938

Merged
merged 7 commits into from Jul 10, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jun 12, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17, along with react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated edx package @edx/frontend-platform
  • Updated paragon to fix react-loading-skeleton issue

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if its not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0513e6c) 85.36% compared to head (478da7a) 85.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #938   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         109      109           
  Lines        2125     2125           
  Branches      607      607           
=======================================
  Hits         1814     1814           
  Misses        296      296           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m Mashal-m marked this pull request as ready for review July 5, 2023 10:32
@Mashal-m Mashal-m requested a review from a team as a code owner July 5, 2023 10:32
@ahtesham-quraish ahtesham-quraish merged commit c978323 into master Jul 10, 2023
6 checks passed
@ahtesham-quraish ahtesham-quraish deleted the mashal-m/react-upgrade-to-v17 branch July 10, 2023 10:48
snglth pushed a commit to Abstract-Tech/community-theme-authn that referenced this pull request Jan 9, 2024
* feat: update react & react-dom to v17

* chore: add enzyme adapter pkg to devDep

* refactor: updated paragon & snapshots

* build: update frontend-platform

---------

Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants