feat: upgraded to node v18, added .nvmrc and updated workflows #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
===========================================
- Coverage 100.00% 95.44% -4.56%
===========================================
Files 123 124 +1
Lines 1274 1338 +64
Branches 250 271 +21
===========================================
+ Hits 1274 1277 +3
- Misses 0 53 +53
- Partials 0 8 +8 ☔ View full report in Codecov by Sentry. |
…ilalqamar95/node-v18-upgrade
…component-header packages
52 tasks
…ilalqamar95/node-v18-upgrade
…ilalqamar95/node-v18-upgrade
| @@ -9,7 +9,7 @@ const courseId = 'a-fake-course-id'; | |||
| const category = 'AFakeCategory'; | |||
| describe('segment service utils', () => { | |||
| beforeAll(() => { | |||
| global.window = Object.create(window); | |||
| global.window ??= Object.create(window); | |||
There was a problem hiding this comment.
Why this statement? The goal here is explicitly to replace the global window
|
@muselesscreator could you please review it again |
abdullahwaheed
pushed a commit
that referenced
this pull request
May 26, 2023
* Merge branch 'master' of github.com:edx/frontend-app-gradebook * feat: upgraded to node v18, added .nvmrc and updated workflows * build: updated frontend-build, frontend-platform, component-footer & component-header packages * refactor: updated packages * fix: resolved test case failure window redefine issue * Merge branch 'master' of github.com:edx/frontend-app-gradebook into bilalqamar95/node-v18-upgrade * refactor: pinned node to v18.15 in nvmrc
mtyaka
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Merge branch 'master' of github.com:edx/frontend-app-gradebook * feat: upgraded to node v18, added .nvmrc and updated workflows * build: updated frontend-build, frontend-platform, component-footer & component-header packages * refactor: updated packages * fix: resolved test case failure window redefine issue * Merge branch 'master' of github.com:edx/frontend-app-gradebook into bilalqamar95/node-v18-upgrade * refactor: pinned node to v18.15 in nvmrc
moonesque
pushed a commit
to edSPIRIT/frontend-app-gradebook
that referenced
this pull request
Nov 11, 2023
…dx#317) * Merge branch 'master' of github.com:edx/frontend-app-gradebook * feat: upgraded to node v18, added .nvmrc and updated workflows * build: updated frontend-build, frontend-platform, component-footer & component-header packages * refactor: updated packages * fix: resolved test case failure window redefine issue * Merge branch 'master' of github.com:edx/frontend-app-gradebook into bilalqamar95/node-v18-upgrade * refactor: pinned node to v18.15 in nvmrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade Node Js from 16 to 18
Description
frontend-platform&frontend-buildversionsedx-internal PR
https://github.com/edx/edx-internal/pull/8338
This needs to be merged together.
Developer Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora