feat: update react & react-dom to v17 #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
=======================================
Coverage 65.36% 65.36%
=======================================
Files 51 51
Lines 820 820
Branches 158 158
=======================================
Hits 536 536
Misses 274 274
Partials 10 10 ☔ View full report in Codecov by Sentry. |
added 2 commits
June 14, 2023 15:14
1 task
… bilalqamar95/react-upgrade-to-v17
…ilalqamar95/react-upgrade-to-v17
jsnwesson
reviewed
Jul 5, 2023
| @@ -66,12 +66,12 @@ | |||
| "@edx/browserslist-config": "^1.1.1", | |||
| "@edx/frontend-build": "12.8.57", | |||
| "@edx/reactifex": "2.2.0", | |||
| "@testing-library/react": "11.2.7", | |||
| "@testing-library/react": "12.1.5", | |||
| "@wojtekmaj/enzyme-adapter-react-17": "0.8.0", | |||
There was a problem hiding this comment.
Given that this is now an archived repo, is the plan to remove this once we bump this repo to v18?
There was a problem hiding this comment.
Yes, this will be removed once this repo is bumped to v18.
justinhynes
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react&react-domto v17 along withtesting-library/react&react-test-rendererto respective compatible versionsenzyme-adapter-react-16with@wojtekmaj/enzyme-adapter-react-17@edx/frontend-platform, @edx/frontend-component-header, @edx/frontend-component-footer