Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #124

Merged
merged 5 commits into from Jul 27, 2023
Merged

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jun 12, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17, along with react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated edx packages @edx/frontend-platform, @edx/frontend-component-header, @edx/frontend-component-footer

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Pull Request Test Coverage Report for Build 5532364704

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.926%

Totals Coverage Status
Change from base Build 5200028657: 0.0%
Covered Lines: 168
Relevant Lines: 309

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dc8c292) 57.64% compared to head (9c4950a) 57.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   57.64%   57.64%           
=======================================
  Files          26       26           
  Lines         399      399           
  Branches       66       66           
=======================================
  Hits          230      230           
  Misses        153      153           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m Mashal-m marked this pull request as ready for review July 6, 2023 06:04
@alangsto alangsto merged commit 559b461 into master Jul 27, 2023
6 checks passed
@alangsto alangsto deleted the mashal-m/react-upgrade-to-v17 branch July 27, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants