feat: update react & react-dom to v17 #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
=======================================
Coverage 73.73% 73.73%
=======================================
Files 3 3
Lines 99 99
Branches 29 29
=======================================
Hits 73 73
Misses 20 20
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
Just curious, why not straight to React 18? Too much breaking changes? |
Yes because of breaking changes, we are planning to upgrade React 18 after React 17. |
|
Is anything blocking progress on this? I don't see any reviewers assigned. |
|
@Toxicom could you please merge this? |
feanil
approved these changes
Jan 29, 2024
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react&react-domto v17, along with@storybook/addon-a11yto respective compatible versionsenzyme-adapter-react-16with@wojtekmaj/enzyme-adapter-react-17