-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to append external IPs in node proxy mode #369
base: master
Are you sure you want to change the base?
Add the ability to append external IPs in node proxy mode #369
Conversation
/assign @FeynmanZhou |
Signed-off-by: Steve Fan <29133953+stevefan1999-personal@users.noreply.github.com>
Signed-off-by: Steve Fan <29133953+stevefan1999-personal@users.noreply.github.com>
efcaa87
to
923c95c
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stevefan1999-personal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stevefan1999-personal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As mentioned by @KONY128, setting the node IP as the external-ip for the LoadBalancer service when using kube-proxy may disrupt the original network and even paralyze the cluster network. Therefore, we do not recommend this practice. |
Description
This is regarded to this comment in the original thread of #214:
We can just make that an add-in feature for people to try, we just don't have to enable it by default. It is not sure why @KONY128 suggested not to that. This is necessary for certain application that listens to load balancer status change and external IP addresses such as external-dns so I think this is more of a necessary evil.
What type of PR is this ?:
Implementation
Related links:
#214 (comment)