Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status to function CRD and support the strategy field in profiles #1201

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

welteki
Copy link
Member

@welteki welteki commented Mar 27, 2024

Description

  • Support changing the deployment strategy for a function through Profiles.
  • Add a status field to the function CRD to track the Profiles that are applied to a function.
  • Update the profile and function CRD template in the OpenFaaS chart and add permission in the operator-crd template to update the function/status resource.

Why is this needed?

  • I have raised an issue to propose this change (required)

  • Tracking applied Profiles in the function status is required for efficient reconciliation by the OpenFaaS Pro operator.

  • Support for changing the deployment strategy type is required to update functions using GPUs in a cluster with limited GPU availability.

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file?

How Has This Been Tested?

New types where used in the pro fork of faas-netes where the support for Profiles is implemented.

Changes for the OpenFaaS chart were verified while testing this feature with faas-netes pro.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
It is recommended that the ResourceVersion field of objects is used to
determine when objects have changed.

Use this field instead of the Generation to track the applied profile
version.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant