Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MindMap to PlantUML #1396

Merged
merged 1 commit into from May 7, 2021
Merged

Change MindMap to PlantUML #1396

merged 1 commit into from May 7, 2021

Conversation

ashleyfrieze
Copy link
Contributor

This has a couple of benefits:

  1. Avoid having to regenerate the .PNG every time the mind map is changed
  2. Renders automatically with white background, even in dark mode

See #1358

@ashleyfrieze
Copy link
Contributor Author

Note: the URL of the mindmap is presently set to this branch on this fork. This is just for illustration. It would need to be set to the master location before merging.

Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is awesome. Thanks for that

@velo velo merged commit ffd3e4a into OpenFeign:master May 7, 2021
@ashleyfrieze
Copy link
Contributor Author

@velo thanks for taking it on. I’m a big fan of the open feign library. Delighted to contribute even a tiny amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants