Fix no response logging on async Feign

[AWinterman]

Copy log level onto asyncBuilder as well as setting it on the builder, so responses get logged in the asynchronous case.

I apologize if this is in the wrong format. You can see a test reproducing the issue below.

I have yet to build the project locally-- I likely won't have time to do that until the morning. The build failure appears to be asking me to add a license header to this file, which I can do but seems unrelated to this issue 🤷

Test Example

import static com.github.tomakehurst.wiremock.client.WireMock.anyUrl;
import static com.github.tomakehurst.wiremock.client.WireMock.get;
import static com.github.tomakehurst.wiremock.client.WireMock.stubFor;
import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.options;
import static org.junit.jupiter.api.Assertions.assertEquals;

import com.github.tomakehurst.wiremock.client.WireMock;
import com.github.tomakehurst.wiremock.common.Slf4jNotifier;
import com.github.tomakehurst.wiremock.junit.WireMockRule;
import feign.AsyncFeign;
import feign.Logger.ErrorLogger;
import feign.Logger.Level;
import feign.RequestLine;
import java.util.concurrent.CompletableFuture;
import org.junit.Rule;
import org.junit.Test;


public class FeignPermissionResourceTest {

  public interface ExampleApi {

    @RequestLine("GET /")
    CompletableFuture<String> hello();
  }

  @Rule
  public WireMockRule wireMockRule = new WireMockRule(
      options()
          .dynamicPort()
          .notifier(new Slf4jNotifier(true))
  );

  @Test
  public void testLoggerFailure() {

    final ExampleApi target = AsyncFeign.asyncBuilder()
        .logger(new ErrorLogger())
        .logLevel(Level.FULL)
        .target(ExampleApi.class, wireMockRule.baseUrl());

    var response = WireMock.aResponse()
        .withStatus(200)
        .withHeader("Content-Type", "text/plain")
        .withBody("hello!");

    stubFor(get(anyUrl()).willReturn(response));

    final CompletableFuture<String> hello = target.hello();

    final String responseText = hello.join();
    assertEquals("hello!", responseText);
  }
}

Output on STDERR

[ExampleApi#hello] ---> GET http://localhost:62764/ HTTP/1.1
[ExampleApi#hello] ---> END HTTP (0-byte body)

Process finished with exit code 0

[velo]

I apologize if this is in the wrong format. You can see a test reproducing the issue below.

just run maven build locally that it will fix the format for you

[AWinterman]

I apologize if this is in the wrong format. You can see a test reproducing the issue below.

just run maven build locally that it will fix the format for you

Done.

[AWinterman]

Thanks for merging this so quickly-- will this apply on the 10.X schedule as well as 11?

[velo]

Thanks for merging this so quickly-- will this apply on the 10.X schedule as well as 11?

11 only.

[AWinterman]

@velo apologies if this is already well documented, but when might I expect the next release to come out? Thanks!

[velo]

Just created 11.3, will be updating release notes shortly.