feat: make helm hooks mandatory #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR @jbouchery! While the team reviews the PR, may I ask you to:
|
|
Hi @rhamzeh, Thanks for the feedback ! I Signed the Linux Foundation's EasyCLA as you said. I also reviewed the merge conflicts but my PR only involve a change of the Helm Chart, not the application. I don't think i have to bump de appVersion in this case. |
jon-whit
reviewed
Jan 30, 2024
| @@ -34,17 +34,6 @@ spec: | |||
| serviceAccountName: {{ include "openfga.serviceAccountName" . }} | |||
| securityContext: | |||
| {{- toYaml .Values.podSecurityContext | nindent 8 }} | |||
| {{- if and (has .Values.datastore.engine (list "postgres" "mysql")) .Values.datastore.applyMigrations }} | |||
There was a problem hiding this comment.
I understand the other changes in this PR, but I don't understand why you dropped this. Could you elaborate on why you removed this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I saw that this PR added the Helm Hooks to the migration job #70. I think it could be better to make them mandatory instead of default in the values (so it can't be overridden). In addition, i deleted the initContainer that is deprecated when using Helm Hooks.
References
The PR introducing the migration Helm Hooks #70
Review Checklist
main