Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add image pull secrets to migration job #134

Conversation

rorynickolls-skyral
Copy link
Contributor

Adds image pull secrets to the migration job.

Description

Image pull secrets are currently configurable for the OpenFGA deployment, but not the migrate job.

This makes it difficult to use the chart in scenarios where you want to pull images from a private registry (e.g. a Docker Hub mirror).

Another option here is to add them to the service account, but I think this way is clearer and compatible if the service account is disabled.

I have tested this locally and it allows the chart to be installed with all images configured to pull from a private registry.

References

If the change warrants more discussion I'm happy to open up an issue - but it looks like something that might have just been missed out.

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rorynickolls-skyral rorynickolls-skyral requested review from a team as code owners May 10, 2024 14:39
Copy link

linux-foundation-easycla bot commented May 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

jon-whit
jon-whit previously approved these changes May 21, 2024
@jon-whit
Copy link
Member

@rorynickolls-skyral you need to bump the chart version as well. Then we can merge 👍

@rorynickolls-skyral
Copy link
Contributor Author

Thanks @jon-whit. Bumped to 0.2.4.

@jon-whit jon-whit merged commit 40ea4e1 into openfga:main May 21, 2024
2 checks passed
@rorynickolls-skyral rorynickolls-skyral deleted the add-image-pull-secrets-to-migration-job branch May 22, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants