fix: add image pull secrets to migration job #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds image pull secrets to the migration job.
Description
Image pull secrets are currently configurable for the OpenFGA deployment, but not the migrate job.
This makes it difficult to use the chart in scenarios where you want to pull images from a private registry (e.g. a Docker Hub mirror).
Another option here is to add them to the service account, but I think this way is clearer and compatible if the service account is disabled.
I have tested this locally and it allows the chart to be installed with all images configured to pull from a private registry.
References
If the change warrants more discussion I'm happy to open up an issue - but it looks like something that might have just been missed out.
Review Checklist
main