feat(java): support validating a json based authorization model #245
+256
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
commented
Apr 24, 2024
| @@ -8,7 +8,7 @@ public class ModelValidationSingleError extends ParsingError { | |||
| public ModelValidationSingleError() {} | |||
|
|
|||
| public ModelValidationSingleError(ErrorProperties properties, ValidationMetadata metadata) { | |||
| super("syntax", properties); | |||
| super("validation", properties); | |||
There was a problem hiding this comment.
This should have been validation as that's what it is in JS
ewanharris
commented
Apr 24, 2024
| @@ -53,20 +64,30 @@ private void validate() throws DslErrorsException { | |||
| errors.raiseSchemaVersionRequired(0, ""); | |||
| } | |||
|
|
|||
| if (schemaVersion != null && schemaVersion.equals("1.1")) { | |||
| if (schemaVersion != null && (schemaVersion.equals("1.1") || schemaVersion.equals("1.2"))) { | |||
There was a problem hiding this comment.
Not sure if there's an easy way we want to handle this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a
validateJsonfunction for the Java package and then adds the JSON only errors that we have added since the Java package was written. It also updates the java-sdk to latest to pull in the modular models metadataNaming wise, I stuck with the existing JS function names of
validateDslandvalidateJson, I also renamed the overall class toModelValidatoras it's no longer solely serving the purpose of DSL validation.References
Review Checklist
main