Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve wrong python SDK Link in intro #746

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

tbcvl
Copy link
Contributor

@tbcvl tbcvl commented May 14, 2024

Description

Fix a bad link in documentation intro page: previous "Python" link lead to java sdk and not python sdk.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • N/A: I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev]
  • The correct base branch is being used, if not main
  • N/A: I have added tests to validate that the change in functionality is working as expected

Previous link lead to java sdk and not python sdk.
@tbcvl tbcvl requested a review from a team as a code owner May 14, 2024 15:49
Copy link

linux-foundation-easycla bot commented May 14, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@rhamzeh rhamzeh changed the title Fix python SDK Link in intro fix: resolve wrong python SDK Link in intro May 14, 2024
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tbcvl !

@rhamzeh rhamzeh enabled auto-merge (squash) May 14, 2024 16:24
@tbcvl
Copy link
Contributor Author

tbcvl commented May 15, 2024

@rhamzeh do you have to the power to relaunch the CI?

@rhamzeh
Copy link
Member

rhamzeh commented May 15, 2024

@rhamzeh do you have to the power to relaunch the CI?

Yep, but don't worry about the failed CI. PR Preview failing is a known issue on external contributions due to lack of the auth token.

We require two approving reviews on docs changes, so this will auto merge as soon as another team member gives it another approving review

@rhamzeh rhamzeh merged commit df51753 into openfga:main May 15, 2024
7 of 8 checks passed
@tbcvl tbcvl deleted the patch-1 branch May 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants