-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: DSL indentation in tests inside pkg server #1620
base: main
Are you sure you want to change the base?
Conversation
I see check on "Pull Request / test (pull_request)" has lots of errors that I can't replicate on my local while running Seems to be integration tests running while dependency (MySQL / GRPC) not ready. E.g.:
May I get any help/support to troubleshoot? |
…pkg server Pushing 1 file at a time to try to trobleshot git test workflow error
85cfff9
to
f907195
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
==========================================
+ Coverage 86.21% 86.26% +0.05%
==========================================
Files 90 90
Lines 8466 8466
==========================================
+ Hits 7298 7302 +4
+ Misses 825 823 -2
+ Partials 343 341 -2 ☔ View full report in Codecov by Sentry. |
…pkg server Pushing 1 file at a time to try to trobleshot git test workflow error
Pushing 1 file at a time to try to troubleshoot git test workflow error
Pushing 1 file at a time to try to troubleshoot git test workflow error
Pushing 1 file at a time to try to troubleshoot git test workflow error. Now going one function at a time to isolate source of error.
TODO [for me]:
|
Pushing remaining test files of pkg server. There's a known issue with some flaky tests (see openfga#1401) that might make github workflow "pull requests / tests" fail
Can't reproduce locally, so pushing to draft PR to observe behavior
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
=======================================
Coverage 86.21% 86.21%
=======================================
Files 90 90
Lines 8466 8466
=======================================
Hits 7298 7298
Misses 825 825
Partials 343 343 ☔ View full report in Codecov by Sentry. |
480fbd8
to
36048db
Compare
Fixes #1339 for package server
Description
Now that openfga/language parser has better support for whitespaces, refactor to
have better readability in the test files.
References
Issue #1302
Continuation of closed PR #1597
Review Checklist
main