Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lime.ndll build on MinGW #1660

Open
wants to merge 6 commits into
base: 8.2.0-Dev
Choose a base branch
from

Conversation

tobil4sk
Copy link
Contributor

@tobil4sk tobil4sk commented Apr 12, 2023

Fixes some issues to allow compiling lime.ndll with MinGW.

I'm not too sure what the best way to deal with the System.cpp situation would be.

@tobil4sk tobil4sk changed the title Fix build issues on MinGW Fix lime.ndll build on MinGW Apr 12, 2023
@tobil4sk
Copy link
Contributor Author

I separated out some of the commits into #1661, because with those commits it's already possible to cross compile projects with mingw with a precompiled lime.ndll.

@DigiEggz
Copy link

DigiEggz commented Aug 25, 2023

I'm interested in testing this build! Could you offer any links to the new precompiled minGW version of lime.ndll? If not, I can look into building from source, but it might be a while.

@tobil4sk
Copy link
Contributor Author

tobil4sk commented Aug 29, 2023

I'm interested in testing this build! Could you offer any links to the new precompiled minGW version of lime.ndll?

Hi sorry, I haven't uploaded the precompiled lime.ndll anywhere. Building from source isn't too complicated as long as you have mingw set up, when I have a look at this again I can try to provide some proper instructions for how to do this. I should have provided instructions originally in the PR, sorry. Once I have a look again I could probably upload a copy of the ndll here as well.

Just a heads up, I managed to get things compiling but the build wasn't really working. When I tried to run a project with the mingw ndll there was no window showing up unfortunately. This will require more investigating to figure out what exactly is wrong. In the meantime I have just been building my actual project code with mingw (with #1661 and the git version of hxcpp) but using the regular Windows lime.ndlls instead of compiling my own mingw copy.

@DigiEggz
Copy link

I'm interested in testing this build! Could you offer any links to the new precompiled minGW version of lime.ndll?

Hi sorry, I haven't uploaded the precompiled lime.ndll anywhere. Building from source isn't too complicated as long as you have mingw set up, when I have a look at this again I can try to provide some proper instructions for how to do this. I should have provided instructions originally in the PR, sorry. Once I have a look again I could probably upload a copy of the ndll here as well.

Just a heads up, I managed to get things compiling but the build wasn't really working. When I tried to run a project with the mingw ndll there was no window showing up unfortunately. This will require more investigating to figure out what exactly is wrong. In the meantime I have just been building my actual project code with mingw (with #1661 and hxcpp patches HaxeFoundation/hxcpp#1044 HaxeFoundation/hxcpp#1045 HaxeFoundation/hxcpp#1046) but using the regular Windows lime.ndlls instead of compiling my own mingw copy.

I'll give that a try! Thanks again for all of the work you've put into this build.

@DigiEggz
Copy link

DigiEggz commented Sep 21, 2023

When trying compiling my app (with this library), I get an error:
Error: /Users/E/Documents/Haxe/hxdiscord_rpc/git/project/discord-rpc/src/connection_win.cpp:8:10: fatal error: 'windows.h' file not found

Do you know what I may have to do in order to get the windows.h header file to be included? I'm not sure if I haven't linked minGW or if it's otherwise not set up correctly.

Edit: I used this guide to manually set some of my paths. I cannot compile to 32-bit (he -32 flag doesn't change anything) and trying to set the MINGW_ROOT path results in a double-concatenated string for some reason, but it otherwise works.

When cross compiling from Linux, header names are case sensitive unlike
on Windows.
This causes issues on mingw, and is no longer needed since openal now
uses std::isfinite (c++11) instead of isfinite.

kcat/openal-soft@3ae1c78
MinGW does not provide comsuppw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants