[HTML5] Preloader does not reflect progress of a packed asset library #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this tackles the same problem as #1542, right? I missed the request there to rebase on the latest development branch, but if desired I can still do that. If this PR is gone with on the other hand, feel free to close that one. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using:
<library name="default" type="zip" />to wrap individual assets like images into a single default.pak file, the preloader
(indirectly) does not take the size of the file into account. So if we have a packed library of e.g.
1MB and no other assets, the preloader bar jumps directly from 0 to 100% as soon as the file
finished loading.
This issue has been mentioned years ago in this thread: [Preloader Progress Doesn’t Update When Using “default” Library](https://community.openfl.org/t/preloader-progress-doesnt-update-when-using-default-library/10688/)
The findings by singmajesty did not get rid of the issue though. The problem is that
PackedAssetLibrary.hx does not monitor the loading of default.pak itself.
This pull request will take care of it.
By the way - HTML5 is surely not the only affected target but it's where I've noticed it.