Use correct ndll loader path on mac arm64 #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
tobil4sk
force-pushed
the
fix/mac-arm64-ndll-path
branch
from
2d66246
to
12fdc19
Compare
tobil4sk
commented
Feb 4, 2024
player-03
reviewed
Feb 5, 2024
player-03
reviewed
Feb 5, 2024
|
This is needed to avoid the neko loading error when running lime tools with a native build of neko on arm64 Mac. It shouldn't change anything when running via rosetta. Anything left to do before this can be merged? @player-03 |
|
I tend to avoid merging Mac-related PRs, since I (mostly) don't use Mac. (With the exception of very small PRs that I can verify just by reading the code.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also requires the same patch in swf: openfl/swf#30