Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin_v3] Allow more capital letters in navigation items #11023

Open
drummer83 opened this issue Jun 15, 2023 · 2 comments · May be fixed by #12477
Open

[Admin_v3] Allow more capital letters in navigation items #11023

drummer83 opened this issue Jun 15, 2023 · 2 comments · May be fixed by #12477
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@drummer83
Copy link
Contributor

Description

OIDC is an abbreviation and should be written in capital letters. In admin style v3 it is currently displayed with just a capital O.
Also the navigation item should have the same spelling as the page headline. No matter the way you put the string in the language file, the will only be a capital letter in the beginning.

Expected Behavior

Use 'OIDC Settings' in the navigation.

Actual Behaviour

It's 'Oidc settings'.

Steps to Reproduce

  1. Activate admin_style_v3 feature toggle.
  2. Select 'Enterprises' from the primary navigation.

Animated Gif/Screenshot

Language file:
image

Admin style v3:
image

Workaround

Severity

bug-s4: it's annoying, but you can use it

Your Environment

  • Version used:
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

@drummer83 drummer83 added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Jun 15, 2023
@RachL RachL added this to the [BUU2] Product List uplift milestone Feb 15, 2024
@dacook dacook linked a pull request May 15, 2024 that will close this issue
7 tasks
@dacook
Copy link
Member

dacook commented May 15, 2024

There's also a design consideration. It is changing the capitalisation style to "Sentence case" to match the new design.

But this issue shows that we can't enforce that with style rules. We have to let the translations choose capitalisation style instead.

@dacook
Copy link
Member

dacook commented May 15, 2024

There's a question about what happens if the translation is missing for the tab name. There's currently some special handling of that case. But a missing translation should be considered an exception, we don't need special handling to format it, we just need to add a translation (in the style chosen for that translation).

So I suggest we remove that special handling.

(For reference, for a missing translation the default Rails behaviour would convert order_cycles to "Order Cycles". Our code would convert it to "Order cycles" to meet the desired capitalisation style. However, we don't need that special handling because we should add the translation instead.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
Status: All the things 💤
Development

Successfully merging a pull request may close this issue.

3 participants