[wip] Don't transform translated values in navigation menu

[dacook]

What? Why?

I was looking to see if it was a good first issue, then I saw the solution so just did it.

• Closes [Admin_v3] Allow more capital letters in navigation items #11023

Eg if :oidc_settings has no translation key:

options[:label].humanize
=> "Oidc settings"

But if it was translated as "OIDC Settings", then it is unchanged.

Work in progress:

• Fix specs
• Check/add a test for the default value
• remove special handling for missing translations

What should we test?

As per issue

Release notes

As it can change what shows in the menu, it's probalby worth announcing as user-facing

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[mkllnk]

Nice initiative! There are some tests that need updating. Did you check for missing translations?

[dacook]

Ah, I should have known it wouldn't be a quick update afterall.

Specs look like an easy fix. But no, I haven't checked if the default value is tested, it's probably not.

Thinking about this, I think we should remove the special handling altogether (more notes added to the above issue). Parking this before I spend more time than it's worth..