Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump wicked_pdf from 2.6.3 to 2.8.0 #12214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 28, 2024

Bumps wicked_pdf from 2.6.3 to 2.8.0.

Changelog

Sourced from wicked_pdf's changelog.

[2.8.0]

New Features

Fixes

[2.7.0]

New Features

Fixes

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [wicked_pdf](https://github.com/mileszs/wicked_pdf) from 2.6.3 to 2.8.0.
- [Release notes](https://github.com/mileszs/wicked_pdf/releases)
- [Changelog](https://github.com/mileszs/wicked_pdf/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mileszs/wicked_pdf/commits)

---
updated-dependencies:
- dependency-name: wicked_pdf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Feb 28, 2024
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. We should test the invoices display well.

@filipefurtad0 filipefurtad0 self-assigned this Mar 5, 2024
@filipefurtad0 filipefurtad0 added pr-staged-uk staging.openfoodnetwork.org.uk and removed pr-staged-uk staging.openfoodnetwork.org.uk labels Mar 5, 2024
@filipefurtad0
Copy link
Contributor

Hey @mkllnk ,

Hum, indeed worth testing manually:

We seem to get an error 500 on bulk invoice print and when printing invoices individually (order edit page):

https://app.bugsnag.com/yaycode/openfoodnetwork-uk/errors/65e7303d74bd9c00081f7bbc?filters[error.status]=open&filters[event.since]=30d&filters[app.release_stage]=staging&event_id=65e7316f00dd930b19d00000

image

This needs some fixing before we can merge.

Moving to dev ready.

@abdellani
Copy link
Member

@filipefurtad0
I'm not able to reproduce the issue locally.

@filipefurtad0 filipefurtad0 added pr-staged-uk staging.openfoodnetwork.org.uk and removed pr-staged-uk staging.openfoodnetwork.org.uk labels Mar 15, 2024
@filipefurtad0
Copy link
Contributor

Humm, I can still see this after staging...
image

But I don't see any bugsnag error. I'll look into the server logs and post back.

@filipefurtad0
Copy link
Contributor

Hey @abdellani ,

Here's the log from the error 500, I hope this helps:

I, [2024-03-15 15:31:08 #3607]  INFO -- : source=rack-timeout id=8472e8f7-7c43-4c05-a99f-e0e602598715 wait=5ms timeout=29995ms state=ready
I, [2024-03-15 15:31:08 #3607]  INFO -- : Started GET "/admin/orders/R115885050/print" for 176.79.242.165 at 2024-03-15 15:31:08 +0000
I, [2024-03-15 15:31:08 #3607]  INFO -- : Processing by Spree::Admin::OrdersController#print as HTML
I, [2024-03-15 15:31:08 #3607]  INFO -- :   Parameters: {"id"=>"R115885050"}
I, [2024-03-15 15:31:08 #3607]  INFO -- :   Rendered spree/admin/orders/invoice4.html.haml (Duration: 1.6ms | Allocations: 205)
I, [2024-03-15 15:31:08 #3607]  INFO -- : Completed 500 Internal Server Error in 369ms (ActiveRecord: 115.9ms | Allocations: 31778)
I, [2024-03-15 15:31:08 #3607]  INFO -- [Bugsnag]: Notifying https://notify.bugsnag.com of TypeError
F, [2024-03-15 15:31:08 #3607] FATAL -- :   
ActionView::Template::Error (no implicit conversion of nil into String):
    1: = pdf_stylesheet_pack_tag "mail"
    2: 
    3: %table{:width => "100%"}
    4:   %tbody
  
app/helpers/application_helper.rb:69:in `pdf_stylesheet_pack_tag'
app/views/spree/admin/orders/invoice4.html.haml:1
app/controllers/spree/admin/orders_controller.rb:112:in `print'
I, [2024-03-15 15:31:08 #3607]  INFO -- : Processing by ErrorsController#internal_server_error as HTML
I, [2024-03-15 15:31:08 #3607]  INFO -- :   Parameters: {"id"=>"R115885050"}
I, [2024-03-15 15:31:08 #3607]  INFO -- :   Rendered errors/internal_server_error.html.haml within layouts/errors (Duration: 1.4ms | Allocations: 95)
I, [2024-03-15 15:31:08 #3607]  INFO -- :   Rendered layout layouts/errors.html.haml (Duration: 2.5ms | Allocations: 158)
I, [2024-03-15 15:31:08 #3607]  INFO -- : Completed 500 Internal Server Error in 5ms (Views: 3.5ms | ActiveRecord: 0.0ms | Allocations: 387)
I, [2024-03-15 15:31:08 #3607]  INFO -- : source=rack-timeout id=8472e8f7-7c43-4c05-a99f-e0e602598715 wait=5ms timeout=29995ms service=585ms state=completed

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Mar 15, 2024
@dacook
Copy link
Member

dacook commented Apr 2, 2024

Requires fix, see the dependency updates guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
Status: Dev ready 👋
Status: Backend Easy
Development

Successfully merging this pull request may close these issues.

None yet

4 participants