Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buu/editing ux #12479

Closed
wants to merge 3 commits into from
Closed

Conversation

dacook
Copy link
Member

@dacook dacook commented May 15, 2024

What? Why?

Some visual cues. too much?

I swear the last commit worked before, I must have borken something.

  • Closes #

Screenshot 2024-05-15 at 4 49 48 pm

What should we test?

  • Visit ... page.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Probably can DRY the code. Also need to confirm design.
The :has selector makes it so easy. Too easy? Not sure about performance.
@dacook dacook marked this pull request as draft May 15, 2024 06:51
@dacook
Copy link
Member Author

dacook commented May 15, 2024

Hi @mariocarabotta, while debugging an issue on staging servers, I tried adding these indicators to show when a row has been updated or has errors.

We had an issue with a particular problem that was hidden, so this would help narrow down issues in that case. I was considering if there'd be a way to detect errors that are not shown, and display the message below the row, but I'm not sure if that's possible.

Of course, we will try and fix any hidden error problems.. but I wondered if this would be helpful in general. What do you think about it?

@dacook
Copy link
Member Author

dacook commented Jun 4, 2024

Discussed with @mariocarabotta : it's complicated to get this right, with a few things to consider:
For example, we already have a coloured bar on the top banner, with a similar red.

So let's park it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant