Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rspec-rails from 4.0.2 to 4.1.2 #7067

Merged
merged 1 commit into from Mar 17, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 11, 2021

Closes #7050
Bumps rspec-rails from 4.0.2 to 4.1.2.

Changelog

Sourced from rspec-rails's changelog.

Development

Full Changelog

5.0.0 / 2021-03-09

Full Changelog

Enhancements:

  • Support new #file_fixture_path and new fixture test support code. (Jon Rowe, #2398)
  • Support for Rails 6.1. (Benoit Tigeot, Jon Rowe, Phil Pirozhkov, and more #2398)

Breaking Changes:

  • Drop support for Rails below 5.2.

4.1.1 / 2021-03-09

Bug Fixes:

  • Remove generated specs when destroying a generated controller. (@​Naokimi, #2475)

4.1.0 / 2021-03-06

Enhancements:

  • Issue a warning when using job matchers with #at mis-match on usec precision. (Jon Rowe, #2350)
  • Generated request specs now have a bare _spec suffix instead of request_spec. (Eloy Espinaco, Luka Lüdicke, #2355, #2356, #2378)
  • Generated scaffold now includes engine route helpers when inside a mountable engine. (Andrew W. Lee, #2372)
  • Improve request spec "controller" scafold when no action is specified. (Thomas Hareau, #2399)
  • Introduce testing snippets concept (Phil Pirozhkov, Benoit Tigeot, #2423)
  • Prevent collisions with let(:name) for Rails 6.1 and let(:method_name) on older Rails. (Benoit Tigeot, #2461)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Mar 11, 2021
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just the tests need to finish.

@dependabot dependabot bot force-pushed the dependabot/bundler/rspec-rails-4.1.2 branch from 86486f0 to a3a8a60 Compare March 11, 2021 19:22
@andrewpbrett
Copy link
Contributor

@dependabot-bot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/rspec-rails-4.1.2 branch from a3a8a60 to 22504eb Compare March 13, 2021 19:25
@Matt-Yorkley
Copy link
Contributor

@dependabot-bot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/rspec-rails-4.1.2 branch from 22504eb to c11b68e Compare March 14, 2021 16:59
@sigmundpetersen
Copy link
Contributor

@dependabot-bot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/rspec-rails-4.1.2 branch from c11b68e to f8091ef Compare March 16, 2021 14:42
@andrewpbrett
Copy link
Contributor

@dependabot-bot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/rspec-rails-4.1.2 branch from f8091ef to 0af046f Compare March 16, 2021 16:40
@sigmundpetersen
Copy link
Contributor

@dependabot-bot rebase

Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 4.0.2 to 4.1.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases)
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](rspec/rspec-rails@v4.0.2...v4.1.2)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rspec-rails-4.1.2 branch from 0af046f to 4adaa6d Compare March 16, 2021 22:33
@Matt-Yorkley
Copy link
Contributor

What dev-test are we waiting for here? There's a couple of well-known flaky specs failing, but other than that it seems fine.

@sauloperez
Copy link
Contributor

it was just a way to put this one aside until the build was passing @Matt-Yorkley

@andrewpbrett
Copy link
Contributor

Github just has the 3 BOM specs red, which should be fixed now. I think we can merge.

@andrewpbrett andrewpbrett merged commit 9aa992b into master Mar 17, 2021
@andrewpbrett andrewpbrett deleted the dependabot/bundler/rspec-rails-4.1.2 branch March 17, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade rspec-rails to 4.1
5 participants