Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update validation env to include openmm #319

Merged
merged 1 commit into from Oct 28, 2022
Merged

update validation env to include openmm #319

merged 1 commit into from Oct 28, 2022

Conversation

pavankum
Copy link
Member

Update validation env to include openmm and pin pint to < 0.20.

@pavankum pavankum requested a review from dotsdl October 26, 2022 19:34
@dotsdl
Copy link
Member

dotsdl commented Oct 28, 2022

Why pint < 0.20? Can you elaborate?

dotsdl
dotsdl approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting this for now; we'll hopefully be able to drop openmm as a dependency again here once openforcefield/openff-qcsubmit#204 is merged.

@dotsdl dotsdl merged commit 1c3311d into master Oct 28, 2022
@pavankum
Copy link
Member Author

Why pint < 0.20? Can you elaborate?

Just as a precaution for the recent changes in pint that may affect openff-units.

@pavankum
Copy link
Member Author

pavankum commented Oct 28, 2022 •
edited

@dotsdl This change is causing the validation failure, python/importlib_metadata#405, entry_points() is a dict now. The failure point is https://github.com/openforcefield/openff-toolkit/blob/main/openff/toolkit/typing/engines/smirnoff/forcefield.py#L86. We have to pin to 4.11.4 for now.

@pavankum
Copy link
Member Author

On second thoughts, it looks like a bad environment resolution by conda (or mamba) on the validation CI

importlib-metadata        5.0.0              pyha770c72_1    conda-forge
importlib_metadata        1.5.0                    py38_0    conda-forge

When I test locally if both are 5.0.0 it works,

importlib-metadata        5.0.0              pyha770c72_1    conda-forge
importlib_metadata        5.0.0                hd8ed1ab_1    conda-forge

@pavankum
Copy link
Member Author

pinning it in #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotsdl dotsdl dotsdl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavankum @dotsdl