♻️(react) use react aria for select menu + modal updates #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bdc44b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
NathanVss
force-pushed
the
fix/select-in-modal
branch
from
3c775df
to
aa2d397
Compare
jbpenrath
reviewed
May 14, 2024
NathanVss
force-pushed
the
fix/select-in-modal
branch
from
b079f53
to
5eedbe4
Compare
I realized that Canvas in mdx are not inside iframe 👀, so I did some edit + avoid flipping for the overlay. |
The way the menu of the select was made was causing it to be cropped inside modals, it was due to the fact the menu was nested inside a position relative parent. Now we use react aria to position in full absolute the menu, making it to be correctly displayed inside modals.
Having the position fixed and at the same time overflow auto on the same element was causing absolute children to be cropped. We need to set those two attribute on two different parent for these children to not be cropped. Yes this is weird, this is CSS.
This default behavior was causing lots of troubles when using modals. For instance the Select value were centered, it was also the case for most of consumer's component inside modals, forcing the users to set text-align:left on their side, resulting in additionnal work. Now we use another approach by using a specific div for the content we want centered.
NathanVss
force-pushed
the
fix/select-in-modal
branch
from
5eedbe4
to
bdc44b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.