Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump husky from 4.3.8 to 5.1.3 #1105

Merged
merged 4 commits into from Mar 3, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 9, 2021

Bumps husky from 4.3.8 to 5.0.9.

Release notes

Sourced from husky's releases.

v5.0.9

  • fix(install): do not fail if not inside a Git directory (closes #851)

See https://github.com/typicode/husky/releases/tag/v5.0.0 for v5 release notes

v5.0.8

  • fix(install): better handle Git <2.9 (#846) closes #844

v5.0.7

  • fix(shell): double quote params (#824)

v5.0.6

  • Remove unused files

v5.0.5

  • Fix custom directory support #827

v5.0.0

馃憠 See https://typicode.github.io/husky for breaking changes and new installation instructions.

Note about the license

Husky 5 is released under The Parity Public License.

It doesn't affect you if you're using husky in an Open Source project or if you're a sponsor. You're free to use it as usual and I hope you'll enjoy this new release 鉂わ笍

If you're using husky in a commercial project, you may want to consider becoming a sponsor to support the project. You can also try it for 30 days.

This is only for a limited time, husky will be MIT again later.

Migrating

Important Husky v5 brings a lot of improvements but is also very different from v4. Git hooks won't work if you only upgrade husky dependency, existing config needs to be migrated too.

The best way to switch to v5 is to follow the new installation instructions and migrate existing hooks command using husky add.

v5.0.0-alpha.5

No release notes provided.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 9, 2021
mantariksh
mantariksh previously approved these changes Feb 10, 2021
@mantariksh mantariksh dismissed their stale review February 10, 2021 07:49

Breaking changes

@mantariksh
Copy link
Contributor

Breaking changes in v5, see docs for migration (looks easy but needs testing)

@mantariksh
Copy link
Contributor

@liangyuanruo @tshuli I made the changes to migrate to v5, could you pls help me double check that they're okay? in particular I'm not sure about the postinstall step - that's clearly only needed in the dev environment

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 22, 2021

A newer version of husky exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@karrui
Copy link
Contributor

karrui commented Mar 1, 2021

@liangyuanruo @tshuli I made the changes to migrate to v5, could you pls help me double check that they're okay? in particular I'm not sure about the postinstall step - that's clearly only needed in the dev environment

Don't think the postinstall step is needed, seems like documentation changed now to prepare; see typicode/husky#890

Should we use their migration tool?

@mantariksh
Copy link
Contributor

mantariksh commented Mar 2, 2021

Don't think the postinstall step is needed, seems like documentation changed now to prepare; see typicode/husky#890

Sure, they just released that a few hours ago, will make the change

Should we use their migration tool?

Didn't work lol all it did was add a pre-commit npm test, otherwise the outcome was exactly the same as what I already did

@mantariksh mantariksh force-pushed the dependabot/npm_and_yarn/husky-5.0.9 branch from 5be904f to 92ad734 Compare March 2, 2021 10:35
@mantariksh mantariksh requested a review from karrui March 3, 2021 01:50
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, remember to change the PR title to 5.1.3 instead

@mantariksh mantariksh merged commit cbc2bd9 into develop Mar 3, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/husky-5.0.9 branch March 3, 2021 03:51
@mantariksh mantariksh changed the title chore(deps-dev): bump husky from 4.3.8 to 5.0.9 chore(deps-dev): bump husky from 4.3.8 to 5.1.3 Mar 3, 2021
@tshuli tshuli mentioned this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants