Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v5.3.0 #1430

Merged
merged 37 commits into from
Mar 23, 2021
Merged

build: release v5.3.0 #1430

merged 37 commits into from
Mar 23, 2021

Commits on Mar 16, 2021

  1. refactor: convert analytics module to TypeScript/fp-ts, remove statis…

    …tics animation on landing page (#1361)
    liangyuanruo committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    8ce6479 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea54cb5 View commit details
    Browse the repository at this point in the history
  3. fix(deps): bump neverthrow from 4.1.1 to 4.2.0 (#1379)

    Bumps [neverthrow](https://github.com/supermacro/neverthrow) from 4.1.1 to 4.2.0.
    - [Release notes](https://github.com/supermacro/neverthrow/releases)
    - [Commits](supermacro/neverthrow@v4.1.1...v4.2.0)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    44de42e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b8352d View commit details
    Browse the repository at this point in the history
  5. chore(deps-dev): bump @types/mongodb from 3.6.9 to 3.6.10 (#1377)

    Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.6.9 to 3.6.10.
    - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
    - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6cb4e98 View commit details
    Browse the repository at this point in the history
  6. fix: add rows attr to email confirmation email body textarea

    added rows attribute to email confirmation textarea to increase height to something reasonable for email
    r00dgirl committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    941b6bf View commit details
    Browse the repository at this point in the history
  7. chore(deps-dev): bump @types/node from 14.14.34 to 14.14.35 (#1378)

    Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.34 to 14.14.35.
    - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
    - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b1ee82b View commit details
    Browse the repository at this point in the history
  8. Merge pull request #1384 from opengovsg/release-v5.2.0

    chore: merge 5.2.0 into develop
    mantariksh committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    cbddbad View commit details
    Browse the repository at this point in the history
  9. fix(deps): bump aws-sdk from 2.863.0 to 2.864.0 (#1388)

    Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.863.0 to 2.864.0.
    - [Release notes](https://github.com/aws/aws-sdk-js/releases)
    - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
    - [Commits](aws/aws-sdk-js@v2.863.0...v2.864.0)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    bc9e994 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7c5cb56 View commit details
    Browse the repository at this point in the history
  11. chore(deps-dev): bump @opengovsg/mockpass from 2.6.6 to 2.6.7 (#1387)

    Bumps [@opengovsg/mockpass](https://github.com/opengovsg/mockpass) from 2.6.6 to 2.6.7.
    - [Release notes](https://github.com/opengovsg/mockpass/releases)
    - [Commits](opengovsg/mockpass@v2.6.6...v2.6.7)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    82421c2 View commit details
    Browse the repository at this point in the history
  12. chore(deps-dev): bump @types/express-serve-static-core (#1390)

    Bumps [@types/express-serve-static-core](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express-serve-static-core) from 4.17.18 to 4.17.19.
    - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
    - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express-serve-static-core)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ba1ed0b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. fix(deps): bump convict from 6.0.0 to 6.0.1 (#1395)

    Bumps [convict](https://github.com/mozilla/node-convict) from 6.0.0 to 6.0.1.
    - [Release notes](https://github.com/mozilla/node-convict/releases)
    - [Changelog](https://github.com/mozilla/node-convict/blob/master/CHANGELOG.md)
    - [Commits](mozilla/node-convict@v6.0.0...v6.0.1)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    ba95eee View commit details
    Browse the repository at this point in the history
  2. fix(deps): bump twilio from 3.57.0 to 3.58.0 (#1394)

    Bumps [twilio](https://github.com/twilio/twilio-node) from 3.57.0 to 3.58.0.
    - [Release notes](https://github.com/twilio/twilio-node/releases)
    - [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md)
    - [Commits](twilio/twilio-node@3.57.0...3.58.0)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    af413d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fe64631 View commit details
    Browse the repository at this point in the history
  4. ref: convert mail and sms services into neverthrown variants (#1344)

    * ref: convert MailService functions to neverthrown variant
    
    * test(MailService): fix tests due to refactoring functions
    
    * wip(SmsService): update send fn to neverthrown variant w cleaner errs
    
    * ref(SmsService): update sendVerificationOtp fn to neverthrown variant
    
    * ref(SmsService): update remaining fns to use neverthrown send fn
    
    * feat: store original thrown twilio error in SmsSendError for logging
    
    * feat(SmsFactory): add passthrough errAsyncs and update tests
    
    * test(SmsService): update tests for neverthrown functions
    
    * fix(BounceSvc): update sms-related fns in service to allow for new fns
    
    * feat(VfnSvc): use new neverthrown fns from mail and sms services
    
    also update tests
    
    * feat(user): handle MissingFeatureError and InvalidNumberError
    
    * feat: show sms/mail error message itself in default case
    
    * feat(EmailSubmissionSvc): remove redundant sendSubmissionToAdmin fn
    
    Directly use refactored function from MailService
    
    * test(EmailSubmissionRoutes): make jest spy promise
    
    test was failing due to old code using await syntax (and thus does not need a resolved value), and the new code uses neverthrow#andThen, which requires a promise to continue
    
    * ref: extract mail send retry into its own private function
    
    * test(MailService): update tests to check for logging of original error
    
    * feat: add additional logging meta to error in twilio send callback
    
    * test: update old jasmine tests to mock with neverthrow
    
    * feat(VfnSvc): return ApplicationError w const str and fieldType meta
    
    * feat: use getMongoErrorMessage util for DatabaseError message
    
    * ref(SmsService): extract renderVerificationSms to smsUtils
    
    * ref(SmsService): rename send to sendSms for clarity
    karrui committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    10e8d7f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    60ccf11 View commit details
    Browse the repository at this point in the history
  6. feat: switch to CorpPass Cloud for test form (#1392)

    * feat: add new CP cloud env vars with defaults
    
    * feat: allow service user to specify useCpCloud
    
    * feat: use CP cloud for test form
    
    * test: update tests with new useCpCloud arg
    
    * chore: log cloud env vars
    
    * fix: convert _id to string
    
    * ref: remove check for isEnabled
    mantariksh committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    0d20e5c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. chore(deps-dev): bump @types/jest from 26.0.20 to 26.0.21 (#1402)

    Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 26.0.20 to 26.0.21.
    - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
    - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    7b66a1d View commit details
    Browse the repository at this point in the history
  2. chore: change verified sms modal copy (#1403)

    to clarify charges
    r00dgirl committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    b93de4e View commit details
    Browse the repository at this point in the history
  3. chore(deps): update spcp-auth-client, mockpass (#1406)

    Pick up the latest versions of spcp-auth-client and mockpass,
    both of which carry xmldom@0.5.0, which addresses a vulnerability
    involving malicious XML input (CVE-2021-21366)
    LoneRifle committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    a048599 View commit details
    Browse the repository at this point in the history
  4. fix(deps): bump aws-sdk from 2.864.0 to 2.866.0 (#1404)

    Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.864.0 to 2.866.0.
    - [Release notes](https://github.com/aws/aws-sdk-js/releases)
    - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
    - [Commits](aws/aws-sdk-js@v2.864.0...v2.866.0)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    22fed19 View commit details
    Browse the repository at this point in the history
  5. chore(deps-dev): bump eslint-plugin-jest from 24.3.1 to 24.3.2 (#1400)

    Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 24.3.1 to 24.3.2.
    - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
    - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
    - [Commits](jest-community/eslint-plugin-jest@v24.3.1...v24.3.2)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    21989d1 View commit details
    Browse the repository at this point in the history
  6. chore(deps-dev): bump ts-jest from 26.5.3 to 26.5.4 (#1399)

    Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 26.5.3 to 26.5.4.
    - [Release notes](https://github.com/kulshekhar/ts-jest/releases)
    - [Changelog](https://github.com/kulshekhar/ts-jest/blob/master/CHANGELOG.md)
    - [Commits](kulshekhar/ts-jest@v26.5.3...v26.5.4)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5bf35ab View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    95fbbc3 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. fix(deps): bump opossum from 5.1.3 to 6.0.0 (#1412)

    Bumps [opossum](https://github.com/nodeshift/opossum) from 5.1.3 to 6.0.0.
    - [Release notes](https://github.com/nodeshift/opossum/releases)
    - [Changelog](https://github.com/nodeshift/opossum/blob/main/CHANGELOG.md)
    - [Commits](nodeshift/opossum@v5.1.3...v6.0.0)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    f9f2a9a View commit details
    Browse the repository at this point in the history
  2. chore(deps-dev): bump jasmine from 3.6.4 to 3.7.0 (#1413)

    Bumps [jasmine](https://github.com/jasmine/jasmine-npm) from 3.6.4 to 3.7.0.
    - [Release notes](https://github.com/jasmine/jasmine-npm/releases)
    - [Commits](jasmine/jasmine-npm@v3.6.4...v3.7.0)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    1ca327d View commit details
    Browse the repository at this point in the history
  3. chore(deps-dev): bump jasmine-core from 3.6.0 to 3.7.1 (#1415)

    Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 3.6.0 to 3.7.1.
    - [Release notes](https://github.com/jasmine/jasmine/releases)
    - [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md)
    - [Commits](jasmine/jasmine@v3.6.0...v3.7.1)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    1b450ba View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. fix(deps): bump neverthrow from 4.2.0 to 4.2.1 (#1416)

    Bumps [neverthrow](https://github.com/supermacro/neverthrow) from 4.2.0 to 4.2.1.
    - [Release notes](https://github.com/supermacro/neverthrow/releases)
    - [Commits](supermacro/neverthrow@v4.2.0...v4.2.1)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    157d638 View commit details
    Browse the repository at this point in the history
  2. fix(deps): bump @sentry/integrations from 6.2.2 to 6.2.3 (#1419)

    Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.2.2 to 6.2.3.
    - [Release notes](https://github.com/getsentry/sentry-javascript/releases)
    - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
    - [Commits](getsentry/sentry-javascript@6.2.2...6.2.3)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    a534741 View commit details
    Browse the repository at this point in the history
  3. feat: create new PATCH endpoint for updating form settings (#1383)

    * feat: create new ApiRouter accessed via '/api/v1'
    
    * feat(AdminFormSvc): add updateFormSettings fn
    
    * feat(AdminFormCtl): add handleUpdateSettings controller handler fn
    
    * feat(AdminFormRoutes): add PATCH settings route and validator
    
    * feat: use new AdminRouter in ApiRouter /api/v1/admin route
    
    * fix: update SettingsUpdateBody to correct setting keys
    
    * feat(AdminFormService): add client service for form settings update
    
    * ref: use new updateFormSettings fn to update settings in client
    
    * feat: create FormSettings type and SettingsUpdateDto type
    
    * ref: use new FormSettings and SettingsUpdateDto types
    
    * feat(FormModel): add & use new getSettings form model instance method
    
    * ref: update comment on returning just settings on successful update
    
    * feat: update API_ROOT_ROUTE to '/api/v3'
    
    * test(FormModel): add tests for getSettings instance method
    
    * test(AdminFormSvc): add tests for updateFormSettings fn
    
    * test(AdminFormCtl): add tests for handleUpdateSettings
    
    * feat: prevent empty settings patch, min 1 key
    
    * ref: return accumulatedForm directly in switch statement
    
    this removes the need for a fromThrowable function, and the UnreachableCaseError class since the return type will not be consistent if a case is missed
    
    * ref: move and add correct hierarchy for new /api/v3 routes
    
    * ref(AdminFormClientCtl): use Object.assign instead of lodash merge
    
    * ref(AdminFormCtl): rename updatedForm to updatedSettings for clarity
    
    * feat(AdminFormClientCtl): add refresh error message on conflict status
    
    * ref(FormModel): extract form setting keys to constant
    
    * feat: remove duplicate admin-form.routes.ts
    
    use the one in `routes` directory instead
    
    * feat(AdminFormSvc): return err if email is updated for encrypt form
    
    * feat(AdminFormRoutes): strengthen joi validator for emails update
    
    * test: add integration tests for PATCH /admin/form/:formId/settings
    
    * test(FormModel): use FORM_SETTING_FIELDS constant in test
    
    * ref: move shared/typings to types/api
    
    * ref: move isEmailModeForm util fn out of types/form to form.utils
    
    types folder should only contain types and not util functions
    
    * feat: set logger key from originalFormId to formId for consistency
    
    * test(AdminFormRoute): use full path in test description
    
    * feat: add dotify-object util fn to generate mongoose update query
    
    * feat: call model findByIdAndUpdate directly
    
    * test(AdminForm): update tests for new update settings flow
    
    * feat: remove error when updating emails for encrypt mode forms
    
    * feat(FormSvc): retrieve form model with only response mode
    
    * feat: remove exported route constants and set route in caller
    karrui committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    ecafc98 View commit details
    Browse the repository at this point in the history
  4. build: automate dependency upgrades using mergify (#1424)

    * build: prevent auto-merge for major version changes
    mantariksh committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    bf8371c View commit details
    Browse the repository at this point in the history
  5. feat: rename /admin/form endpoint to /admin/forms, correct dir struct…

    …ure of /api/v3 routes (#1425)
    karrui committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0d488b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Configuration menu
    Copy the full SHA
    3bf1010 View commit details
    Browse the repository at this point in the history
  2. fix(deps): bump libphonenumber-js from 1.9.13 to 1.9.14 (#1417)

    Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.9.13 to 1.9.14.
    - [Release notes](https://gitlab.com/catamphetamine/libphonenumber-js/tags)
    - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
    - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.9.13...v1.9.14)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    326ff82 View commit details
    Browse the repository at this point in the history
  3. fix(deps): bump celebrate from 13.0.4 to 14.0.0 (#1423)

    Bumps [celebrate](https://github.com/arb/celebrate) from 13.0.4 to 14.0.0.
    - [Release notes](https://github.com/arb/celebrate/releases)
    - [Commits](arb/celebrate@v13.0.4...v14.0.0)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    409775b View commit details
    Browse the repository at this point in the history
  4. chore: bump version to v5.3.0

    karrui committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    36c9bd8 View commit details
    Browse the repository at this point in the history