Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318422: Allow poller threads be virtual threads #247

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 8, 2024

Fixes a Loom performance problem.

Additional testing:

  • Linux x86_64 fastdebug, all passes
  • Linux x86_64 fastdebug, all passes with Virtual scheduler

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318422 needs maintainer approval

Issue

  • JDK-8318422: Allow poller threads be virtual threads (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/247/head:pull/247
$ git checkout pull/247

Update a local copy of the PR:
$ git checkout pull/247
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 247

View PR using the GUI difftool:
$ git pr show -t 247

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/247.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c099cf53f25496c99629dc578045aa5186e1109d 8318422: Allow poller threads be virtual threads Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant