Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308966: Add intrinsic for float/double modulo for x86 AVX2 and AVX512 #273

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 20, 2024

WIP.

Blender.java
  17.0.10:       1865 ms
  20.0.2:        1838 ms
  21u-dev:       1853 ms
  this backport: 1986 ms

Blender2.java
  17.0.10:        138 ms
  20.0.2:         204 ms
  21u-dev:        205 ms
  this backport:  123 ms

Blender4.java
  17.0.10:       1594 ms
  20.0.2:         473 ms
  21u-dev:        466 ms
  this backport:  383 ms

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8314056 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8308966 needs maintainer approval

Issues

  • JDK-8308966: Add intrinsic for float/double modulo for x86 AVX2 and AVX512 (Enhancement - P4)
  • JDK-8314056: Remove runtime platform check from frem/drem (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/273/head:pull/273
$ git checkout pull/273

Update a local copy of the PR:
$ git checkout pull/273
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 273

View PR using the GUI difftool:
$ git pr show -t 273

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/273.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5d5ae35288989fcfabdea013b6e3cdafe359f0df 8308966: Add intrinsic for float/double modulo for x86 AVX2 and AVX512 Feb 20, 2024
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 20, 2024
@shipilev
Copy link
Member Author

/issue add JDK-8314056

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@shipilev
Adding additional issue to issue list: 8314056: Remove runtime platform check from frem/drem.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

…VX512

Backport 5d5ae35288989fcfabdea013b6e3cdafe359f0df
Backport ce2a7ea40a22c652e5f8559c91d5eea197e2d708
@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant