Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325494: C2: Broken graph after not skipping CastII node anymore for Assertion Predicates after JDK-8309902 #509

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 18, 2024

WIP.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325494 needs maintainer approval

Issue

  • JDK-8325494: C2: Broken graph after not skipping CastII node anymore for Assertion Predicates after JDK-8309902 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/509/head:pull/509
$ git checkout pull/509

Update a local copy of the PR:
$ git checkout pull/509
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/509/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 509

View PR using the GUI difftool:
$ git pr show -t 509

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/509.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9fd78022b19149ade40f92749f0b585ecfd41410 8325494: C2: Broken graph after not skipping CastII node anymore for Assertion Predicates after JDK-8309902 Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

This backport pull request has now been updated with issue from the original commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant