Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 #523

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 23, 2024

WIP.

Uncleanliness comes from JDK 21 not having JDK-8313882, so I had to rewrite the incoming hunks back to INT64_FORMAT and int64_t casts. Another uncleanliness is from not having JDK-8310906, which introduced pointer_delta_as_int.

I would probably wait for that to land, which would make this backport clean.

Additional testing:

  • MacOS AArch64 server fastdebug, new regression tests fail without the fix, pass with it
  • Linux x86_64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8327743 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/523/head:pull/523
$ git checkout pull/523

Update a local copy of the PR:
$ git checkout pull/523
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 523

View PR using the GUI difftool:
$ git pr show -t 523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/523.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 274c805c5137d9080a7670d864ecca8a0befc3f6 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 23, 2024
@shipilev shipilev marked this pull request as ready for review April 23, 2024 10:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 23, 2024
@shipilev shipilev marked this pull request as draft April 23, 2024 10:48
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 23, 2024
@shipilev shipilev force-pushed the JDK-8327743-loom-jni-monitor-count branch from 1a23cf3 to 56522fa Compare April 29, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant