Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331164: createJMHBundle.sh download jars fail when url needed to be redirected #543

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 29, 2024

Hi,
This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected.
Only change devkit shell script, the risk is low.


Progress

  • JDK-8331164 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331164: createJMHBundle.sh download jars fail when url needed to be redirected (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/543/head:pull/543
$ git checkout pull/543

Update a local copy of the PR:
$ git checkout pull/543
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 543

View PR using the GUI difftool:
$ git pr show -t 543

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/543.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331164: createJMHBundle.sh download jars fail when url needed to be redirected

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • dc8b95f: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
  • 9971c63: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
  • 97c01b1: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • 9326d88: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified
  • 87670e7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 56fdca3: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 0d0cf83: 8331746: Create a test to verify that the cmm id is not ignored
  • aa66422: 8333093: Incorrect comment in zAddress_aarch64.cpp
  • fb7713d: 8331714: Make OopMapCache installation lock-free
  • a3b14cf: 8330576: ZYoungCompactionLimit should have range check
  • ... and 38 more: https://git.openjdk.org/jdk21u-dev/compare/153de5aeba5bd8378b5a625d482ece524453e5f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport eb88343fb763ee89010b7a9879638152decc6892 8331164: createJMHBundle.sh download jars fail when url needed to be redirected Apr 29, 2024
@openjdk
Copy link

openjdk bot commented Apr 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Apr 29, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 29, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented May 2, 2024

Hi @sendaoYan ,
The fix request comment is missing. Please backport to 22 first. Think about waiting for October release started on May 29.

@openjdk openjdk bot removed the approval label May 2, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented May 2, 2024

Hi @sendaoYan , The fix request comment is missing. Please backport to 22 first. Think about waiting for October release started on May 29.

OK, thanks for the advice. The jdk22 backport has been created.

@sendaoYan
Copy link
Member Author

/approval request Clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. Only change devkit shell script, the risk is low.

@openjdk
Copy link

openjdk bot commented May 2, 2024

@sendaoYan
8331164: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 2, 2024
@sendaoYan
Copy link
Member Author

@GoeLin Thanks for the approve.

@sendaoYan
Copy link
Member Author

After May 29, I will try to merge this PR.

@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 31, 2024
@openjdk
Copy link

openjdk bot commented May 31, 2024

@sendaoYan
Your change (at version 29121c6) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 31, 2024

Going to push as commit 362ecac.
Since your change was applied there have been 48 commits pushed to the master branch:

  • dc8b95f: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
  • 9971c63: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
  • 97c01b1: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • 9326d88: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified
  • 87670e7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 56fdca3: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 0d0cf83: 8331746: Create a test to verify that the cmm id is not ignored
  • aa66422: 8333093: Incorrect comment in zAddress_aarch64.cpp
  • fb7713d: 8331714: Make OopMapCache installation lock-free
  • a3b14cf: 8330576: ZYoungCompactionLimit should have range check
  • ... and 38 more: https://git.openjdk.org/jdk21u-dev/compare/153de5aeba5bd8378b5a625d482ece524453e5f7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2024
@openjdk openjdk bot closed this May 31, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 31, 2024
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 31, 2024
@openjdk
Copy link

openjdk bot commented May 31, 2024

@shipilev @sendaoYan Pushed as commit 362ecac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants