Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325587: Shenandoah: ShenandoahLock should allow blocking in VM #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmyxym
Copy link

@mmyxym mmyxym commented May 9, 2024

Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock.

Additional testing:

  • Linux aarch64 server fastdebug, hotspot/jtreg/tier1 with +UseShenandoahGC

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325587 needs maintainer approval

Issue

  • JDK-8325587: Shenandoah: ShenandoahLock should allow blocking in VM (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/560/head:pull/560
$ git checkout pull/560

Update a local copy of the PR:
$ git checkout pull/560
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/560/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 560

View PR using the GUI difftool:
$ git pr show -t 560

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/560.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 9, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 492e8bf563135d27b46fde198880e62d5f1940e8 8325587: Shenandoah: ShenandoahLock should allow blocking in VM May 9, 2024
@openjdk
Copy link

openjdk bot commented May 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 9, 2024

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2024
@mlbridge
Copy link

mlbridge bot commented May 9, 2024

Webrevs

@mmyxym
Copy link
Author

mmyxym commented May 9, 2024

/approval request Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. Risk is quite low.

@openjdk
Copy link

openjdk bot commented May 9, 2024

@mmyxym
8325587: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 9, 2024
@GoeLin
Copy link
Member

GoeLin commented May 10, 2024

Please backport to 22 first.

@shipilev
Copy link
Member

Too early for 21u-dev anyway; there are follow-up improvements that we want to resolve first, and then backport all of them at once, so that JDK 21 is not in some intermediate state.

@RealCLanger
Copy link
Contributor

Too early for 21u-dev anyway; there are follow-up improvements that we want to resolve first, and then backport all of them at once, so that JDK 21 is not in some intermediate state.

Rampdown for 21.0.4 started. So, @shipilev, is it time now to approve this for 21.0.5 or shall we wait?

@shipilev
Copy link
Member

Rampdown for 21.0.4 started. So, @shipilev, is it time now to approve this for 21.0.5 or shall we wait?

We are working on JDK-8331411, I would instead prefer wait for that to complete and then backport both back to back.

@RealCLanger
Copy link
Contributor

Rampdown for 21.0.4 started. So, @shipilev, is it time now to approve this for 21.0.5 or shall we wait?

We are working on JDK-8331411, I would instead prefer wait for that to complete and then backport both back to back.

OK, then I'll remove the fix-request label for now. Please re-request when this is ready.

@openjdk openjdk bot removed the approval label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
4 participants