Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330027: Identity hashes of archived objects must be based on a reproducible random seed #562

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented May 10, 2024

This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details.

I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both

8251330: Reorder CDS archived heap to speed up relocation
8329431: Improve speed of writing CDS heap objects
were missing.

I also had to change CDSConfig::is_dumping_static_archive() - which only exists in JDK 22 and later - to the technically equal DumpSharedSpaces.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330027 needs maintainer approval

Issue

  • JDK-8330027: Identity hashes of archived objects must be based on a reproducible random seed (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/562/head:pull/562
$ git checkout pull/562

Update a local copy of the PR:
$ git checkout pull/562
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/562/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 562

View PR using the GUI difftool:
$ git pr show -t 562

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/562.diff

Webrev

Link to Webrev Comment

…ducible random seed

Reviewed-by: ccheung, iklam
@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9f43ce5a725b212cec0f3cd17491c4bada953676 8330027: Identity hashes of archived objects must be based on a reproducible random seed May 10, 2024
@openjdk
Copy link

openjdk bot commented May 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 10, 2024
@tstuefe tstuefe marked this pull request as ready for review May 11, 2024 05:24
@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2024
@mlbridge
Copy link

mlbridge bot commented May 11, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest removing the empty line, too.

src/hotspot/share/cds/heapShared.cpp Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented May 13, 2024

⚠️ @tstuefe This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@tstuefe
Copy link
Member Author

tstuefe commented May 14, 2024

Thanks @TheRealMDoerr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants