-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8330027: Identity hashes of archived objects must be based on a reproducible random seed #562
base: master
Are you sure you want to change the base?
Conversation
…ducible random seed Reviewed-by: ccheung, iklam
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I suggest removing the empty line, too.
|
Thanks @TheRealMDoerr ! |
This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details.
I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both
I also had to change
CDSConfig::is_dumping_static_archive()
- which only exists in JDK 22 and later - to the technically equalDumpSharedSpaces
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/562/head:pull/562
$ git checkout pull/562
Update a local copy of the PR:
$ git checkout pull/562
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/562/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 562
View PR using the GUI difftool:
$ git pr show -t 562
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/562.diff
Webrev
Link to Webrev Comment