Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309685: Fix -Wconversion warnings in assembler and register code #567

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 13, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8309685 needs maintainer approval
  • JDK-8331421 needs maintainer approval

Issues

  • JDK-8309685: Fix -Wconversion warnings in assembler and register code (Enhancement - P4)
  • JDK-8331421: ubsan: vmreg.cpp checking error member call on misaligned address (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/567/head:pull/567
$ git checkout pull/567

Update a local copy of the PR:
$ git checkout pull/567
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 567

View PR using the GUI difftool:
$ git pr show -t 567

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/567.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 230bcb769a2701b80b4a12a39785f88a1db48ba9 8309685: Fix -Wconversion warnings in assembler and register code May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 13, 2024
@shipilev
Copy link
Member Author

/issue add JDK-8331421

@openjdk
Copy link

openjdk bot commented May 13, 2024

@shipilev
Adding additional issue to issue list: 8331421: ubsan: vmreg.cpp checking error member call on misaligned address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant