Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all #569

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 14, 2024

Hi all,
This is backport of JDK-8331466. This backport is not clean because the line number of 8227120 has changed from 127 to 137. Only change the Problemlist.txt, the risk is low.

Thanks
sendao


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331466 needs maintainer approval

Issue

  • JDK-8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/569/head:pull/569
$ git checkout pull/569

Update a local copy of the PR:
$ git checkout pull/569
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 569

View PR using the GUI difftool:
$ git pr show -t 569

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/569.diff

Webrev

Link to Webrev Comment

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • ff295b7: 8316138: Add GlobalSign 2 TLS root certificates
  • 2dc90b5: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16
  • 9047499: 8331298: avoid alignment checks in UBSAN enabled build
  • f953b8a: 8312218: Print additional debug information when hitting assert(in_hash)
  • 0a2e2e7: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
  • 6b0467c: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 87fe0d2: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • 9b8f988: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • 30f0779: 8331167: UBSan enabled build fails in adlc on macOS
  • fdb82f4: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/fbb0f4c46446ab50a632b7d73244e5c334eb60c5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 440782e0160f867f08afbec0abf48d557a522c72 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 14, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request This is backport of JDK-8331466. Only change the Problemlist.txt, the risk is low.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan
8331466: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 14, 2024
@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 18, 2024
@openjdk
Copy link

openjdk bot commented May 18, 2024

@sendaoYan
Your change (at version 761a6b0) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 21, 2024

Going to push as commit 8ff8163.
Since your change was applied there have been 16 commits pushed to the master branch:

  • c44d4e9: 8321107: Add more test cases for JDK-8319372
  • ff295b7: 8316138: Add GlobalSign 2 TLS root certificates
  • 2dc90b5: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16
  • 9047499: 8331298: avoid alignment checks in UBSAN enabled build
  • f953b8a: 8312218: Print additional debug information when hitting assert(in_hash)
  • 0a2e2e7: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
  • 6b0467c: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 87fe0d2: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • 9b8f988: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • 30f0779: 8331167: UBSan enabled build fails in adlc on macOS
  • ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/fbb0f4c46446ab50a632b7d73244e5c334eb60c5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 21, 2024
@openjdk openjdk bot closed this May 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

@TheRealMDoerr @sendaoYan Pushed as commit 8ff8163.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks for the approve and sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants