-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC #575
Conversation
Hi @pengxialong, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pengxialong" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
@pengxiaolong This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
Webrevs
|
/approval JDK-8328075 request backport to jdk21 |
@pengxialong |
|
/integrate |
@pengxiaolong |
/sponsor |
Going to push as commit dc8b95f.
Your commit was automatically rebased without conflicts. |
@shipilev @pengxiaolong Pushed as commit dc8b95f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/575/head:pull/575
$ git checkout pull/575
Update a local copy of the PR:
$ git checkout pull/575
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/575/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 575
View PR using the GUI difftool:
$ git pr show -t 575
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/575.diff
Webrev
Link to Webrev Comment