Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC #575

Closed
wants to merge 2 commits into from

Conversation

pengxiaolong
Copy link
Contributor

@pengxiaolong pengxiaolong commented May 15, 2024


Progress

  • Change must not contain extraneous whitespace
  • JDK-8328075 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/575/head:pull/575
$ git checkout pull/575

Update a local copy of the PR:
$ git checkout pull/575
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 575

View PR using the GUI difftool:
$ git pr show -t 575

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/575.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2024

Hi @pengxialong, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pengxialong" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@pengxiaolong
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label May 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2024

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

openjdk bot commented May 15, 2024

@pengxiaolong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • 9971c63: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
  • 97c01b1: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • 9326d88: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified
  • 87670e7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 56fdca3: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 0d0cf83: 8331746: Create a test to verify that the cmm id is not ignored
  • aa66422: 8333093: Incorrect comment in zAddress_aarch64.cpp
  • fb7713d: 8331714: Make OopMapCache installation lock-free
  • a3b14cf: 8330576: ZYoungCompactionLimit should have range check
  • 9fcb4cd: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
  • ... and 34 more: https://git.openjdk.org/jdk21u-dev/compare/035e3144674d494919283941a2e1f3f6dddefaeb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 80ccc989a892e4d9f4e2c9395a100cfabbdcda64 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

This backport pull request has now been updated with issue from the original commit.

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

⚠️ @pengxialong This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2024
@mlbridge
Copy link

mlbridge bot commented May 23, 2024

Webrevs

@pengxiaolong
Copy link
Contributor Author

/approval JDK-8328075 request backport to jdk21

@openjdk
Copy link

openjdk bot commented May 23, 2024

@pengxialong
JDK-8328075: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 23, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

⚠️ @pengxiaolong the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8328075
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 29, 2024
@pengxiaolong
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 30, 2024
@openjdk
Copy link

openjdk bot commented May 30, 2024

@pengxiaolong
Your change (at version c061eba) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 30, 2024

Going to push as commit dc8b95f.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 9971c63: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
  • 97c01b1: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • 9326d88: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified
  • 87670e7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 56fdca3: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 0d0cf83: 8331746: Create a test to verify that the cmm id is not ignored
  • aa66422: 8333093: Incorrect comment in zAddress_aarch64.cpp
  • fb7713d: 8331714: Make OopMapCache installation lock-free
  • a3b14cf: 8330576: ZYoungCompactionLimit should have range check
  • 9fcb4cd: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
  • ... and 34 more: https://git.openjdk.org/jdk21u-dev/compare/035e3144674d494919283941a2e1f3f6dddefaeb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2024
@openjdk openjdk bot closed this May 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 30, 2024
@openjdk
Copy link

openjdk bot commented May 30, 2024

@shipilev @pengxiaolong Pushed as commit dc8b95f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants