Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin #578

Closed

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented May 16, 2024

I'd like to do the backport because jdk 21 is affected by the issue. The included test hangs without the change.
Besides it will reduce the noise in jck tests we're doing regularily (the test api/java_net/ServerSocket/AcceptInterruptibleTests_PlatformThreads fails sometimes because of the issue).

I'd consider the risk low-medium.

Tested with the included test.

The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC).
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323782 needs maintainer approval

Issue

  • JDK-8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/578/head:pull/578
$ git checkout pull/578

Update a local copy of the PR:
$ git checkout pull/578
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/578/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 578

View PR using the GUI difftool:
$ git pr show -t 578

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/578.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2024

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2024

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

  • d7c7326: 8331885: C2: meet between unloaded and speculative types is not symmetric
  • 8991255: 8326734: text-decoration applied to lost when mixed with or
  • ccee9d0: 8332499: Gtest codestrings.validate_vm fail on linux x64 when hsdis is present
  • 33ba538: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
  • ce34aa9: 8332885: Clarify failure_handler self-tests
  • a160bd4: 8294148: Support JSplitPane for instructions and test UI
  • d275f51: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • 9fef7d8: 8325616: JFR ZGC Allocation Stall events should record stack traces
  • 24300eb: 8320602: Lock contention in SchemaDVFactory.getInstance()
  • d87f5a3: 8329995: Restricted access to /proc can cause JFR initialization to crash
  • ... and 79 more: https://git.openjdk.org/jdk21u-dev/compare/6b0467c4736b9bda7fc7650f510754ef91be79f0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1188d404bc4879fc388209cd32e6c4e46178e200 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added approval and removed approval labels Jun 5, 2024
@reinrich reinrich marked this pull request as ready for review June 6, 2024 07:54
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

⚠️ @reinrich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 6, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 6, 2024
@reinrich
Copy link
Member Author

reinrich commented Jun 7, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

Going to push as commit 8204bd7.
Since your change was applied there have been 92 commits pushed to the master branch:

  • 1bb396f: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute
  • f9de294: 8331931: JFR: Avoid loading regex classes during startup
  • ace9524: 8329665: fatal error: memory leak: allocating without ResourceMark
  • d7c7326: 8331885: C2: meet between unloaded and speculative types is not symmetric
  • 8991255: 8326734: text-decoration applied to lost when mixed with or
  • ccee9d0: 8332499: Gtest codestrings.validate_vm fail on linux x64 when hsdis is present
  • 33ba538: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
  • ce34aa9: 8332885: Clarify failure_handler self-tests
  • a160bd4: 8294148: Support JSplitPane for instructions and test UI
  • d275f51: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • ... and 82 more: https://git.openjdk.org/jdk21u-dev/compare/6b0467c4736b9bda7fc7650f510754ef91be79f0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2024
@openjdk openjdk bot closed this Jun 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2024
@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@reinrich Pushed as commit 8204bd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant