Trying to fix CI #10983
Merged
Trying to fix CI #10983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2020
tschaub
approved these changes
Apr 29, 2020
|
It looks like a bug in node that affected puppeteer has been fixed nodejs/node#32968. No reason to rush it, but it may be safe to upgrade again. See also puppeteer/puppeteer#5719. |
|
@tschaub Done already by @dependabot, in #11002. |
|
#11002 brought in puppeteer@3.0.2, which only logged an error in Node 14. This update is what was causing builds to fail. It looks like #11032 will bring in puppeteer@3.0.4, which is the version that works with Node 14.1 and doesn't log a warning (see puppeteer/puppeteer#5816). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like recent versions of Puppeteer do not work with node 14, which is what CircleCI is using now. This pull request fixes the CI, which is broken for all new pull requests since some time yesterday.