Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mocha to version 2.4.2 πŸš€ #4726

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello πŸ‘‹

πŸš€πŸš€πŸš€

mocha just published its new version 2.4.2, which is not covered by your current version range.

If this pull request passes your tests you can publish your software with the latest version of mocha – otherwise use this branch to work on adaptions and fixes.

Happy fixing and merging 🌴


The new version differs by 72 commits (ahead by 72, behind by 1).

  • 753a511 Release v2.4.2
  • 8aafbb5 rebuild
  • 337e863 update CHANGELOG; add link to CHANGELOG in README.md
  • f87395c Merge pull request #2074 from gyandeeps/master
  • d8ffcfb Fix: reporters with chalk functions (fixes #2073)
  • eef307d Merge pull request #2072 from thedark1337/master
  • 9f3774f Fix #2071: Removed color code to fix Chalk colors
  • a661e6c Merge pull request #2053 from mislav/window-vs-global
  • aa550e1 Release v2.4.1
  • 33b7261 rebuild mocha.js
  • 761fa17 rename HISTORY.md => CHANGELOG.md
  • 623c9b6 increase retry test timeout
  • f00c197 Merge pull request #2068 from danielstjules/dstjules/test-body
  • d59cc6c Fix #2067: HTML/DOC reporter regression with async failures
  • a25ac95 Build browser mocha for 2.4.0

There are 72 commits in total. See the full diff.


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚑

fredj added a commit that referenced this pull request Jan 27, 2016
Update mocha to version 2.4.2 πŸš€
@fredj fredj merged commit 551a2ed into master Jan 27, 2016
@fredj fredj deleted the greenkeeper-mocha-2.4.2 branch January 27, 2016 13:18
@bjornharrtell
Copy link
Contributor

@fredj - this seem to have made the test output not nice on Travis, see https://travis-ci.org/openlayers/ol3/builds/105162119 compared to https://travis-ci.org/openlayers/ol3/builds/105161059.

Strangely the output is fine when run locally for me.

@tschaub
Copy link
Member

tschaub commented Jan 27, 2016

@bjornharrtell experimenting with color suppression in #4745. With 551a2ed, I'm not seeing colors in my terminal. Are you?

@bjornharrtell
Copy link
Contributor

Ah yes didn't notice before but yes no color with commit 551a2ed.

I'm not sure what is going on with mocha, they released 2.4.3 with fixes that might be related but that seem to make the build stall completely - #4743.

@fredj
Copy link
Member

fredj commented Jan 28, 2016

Sorry I didn't look at the Travis output ...

@tschaub
Copy link
Member

tschaub commented Jan 28, 2016

No problem @fredj - I don't think I would have either. Though I'm going to look at Travis more closely for future upgrades.

Before upgrading Mocha, we need to make sure that at least mochajs/mocha#2080 is addressed. Ideally, we wouldn't upgrade until Mocha itself is being tested in Phantom (see mochajs/mocha#2079).

I'm also interested in seeing if we can swap out mocha-phantomjs-core. I've found the code pretty hard to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants