Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 integration for Linting #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xtanion
Copy link
Contributor

@xtanion xtanion commented May 16, 2023

[WIP]
Creating an initial draft for the flake8 integration in Software Discovery Tool
TODO:

  • Setting up GitHub workflows
  • Moving the entire codebase to follow Flake8

Please take a look @pleia2 @arshPratap

Signed-off-by: xtanion <anandshivam54321@gmail.com>
Signed-off-by: xtanion <anandshivam54321@gmail.com>
@xtanion
Copy link
Contributor Author

xtanion commented May 19, 2023

Hi @pleia2, Sorry for messaging you this late. We should merge this PR first since we've decided to move forward with the Flake8 linting format. It'll add the GitHub workflow. Initially, I was planning to change everything in just one PR, but it'll be a hassle to review manually & if we've flake8 workflow already set up, I'll do half of the jobs for us (that is, checking the PR). Please let me know your thought on this. Thanks.

@pleia2
Copy link
Contributor

pleia2 commented May 19, 2023

No decision has been made regarding linting format or other coding standards. Please bring this up at the team meeting on Tuesday, May 23rd.

@pleia2
Copy link
Contributor

pleia2 commented May 22, 2023

Details for our upcoming meeting, where we can discuss this, can be found on our calendar: https://lists.openmainframeproject.org/g/software-discovery-tool-discussion/calendar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants