added automation for z/OS open tools #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aashish-khatri <aashishkhatri809@gmail.com>
xtanion
reviewed
May 16, 2023
There was a problem hiding this comment.
Hi @aashish-khatri, PTAL at my comments below, There are a few things you might need to change.
Also, note that you need to crop the name of the package and remove the suffix port. For eg: emacsport changes to emacs. As you can see in the file created by @arshPratap.
Thanks.
| repo_info = {"packageName":repo["name"],"description":repo["description"],"version":""} | ||
| zOS_list.append(repo_info) | ||
|
|
||
| with open('ZOSOpenTools.json','w') as file: |
There was a problem hiding this comment.
This will save the json file in the pwd, we may want to move it to ./distro_data/ instead
| @@ -249,6 +250,24 @@ def rockylinux(): | |||
| DATA.close() | |||
| print(f"Saved!\nfilename: {q}") | |||
|
|
|||
| def zOSOpenTools(): | |||
| url = "https://api.github.com/users/ZOSOpenTools/repos" | |||
There was a problem hiding this comment.
If you use this URL, you'll not find all repository names in your response as you can see in your ZOSOpentools.json. Refer to this.
| zOS_list.append(repo_info) | ||
|
|
||
| with open('ZOSOpenTools.json','w') as file: | ||
| json.dump(zOS_list,file,indent=2) |
There was a problem hiding this comment.
Saving it directly will erase all the previous data in the json. You should compare the new data with the old one and append it to the end of the file.
There was a problem hiding this comment.
We actually do just clobber old versions of the files 😆 so this is in keeping with the rest of the tool. I think it's OK, but something we should address more holistically. Can you create an issue for addressing this tool-wide?
There was a problem hiding this comment.
@pleia2 I think its OK for now , we need to keep in mind the changes we are going to add in the future for the SQL based database design and I dont think creating any issue will be required for now .
|
@aashish-khatri In addition to above, you'll also want to add ZOSOpenTools.json to src/config/supported_distros.py |
pleia2
added a commit
to openmainframeproject/software-discovery-tool-data
that referenced
this pull request
Dec 19, 2023
In issue #49 a case was made that we have several sources for open source software being developed for IBM z/OS and it now makes sense to split up the repositories for easier maintenance and improved accuracy. This commit splits out the following: - Rocket Software into ZOS_Rocket_Software.json - Everything from github.com/IBM/IBM-Z-zOS/ into IBM_Z_zOS.json - Everything maintained by the Open Mainframe Project into ZOS_OMP.json Once this split is completed, we will work on updates to these files. ZOS_Software_List.json remains as a generic place to put any software that doesn't neatly fit into another category, but I have removed all tools related to the z/OS Open Tools project, since it's very outdated and there's another effort in progress to complete adding these tools into their own source file (see: openmainframeproject/software-discovery-tool#124). Signed-off-by: Elizabeth K. Joseph <lyz@princessleia.com>
pleia2
added a commit
to openmainframeproject/software-discovery-tool-data
that referenced
this pull request
Mar 28, 2024
In issue #49 a case was made that we have several sources for open source software being developed for IBM z/OS and it now makes sense to split up the repositories for easier maintenance and improved accuracy. This commit splits out the following: - Rocket Software into ZOS_Rocket_Software.json - Everything from github.com/IBM/IBM-Z-zOS/ into IBM_Z_zOS.json - Everything maintained by the Open Mainframe Project into ZOS_OMP.json Once this split is completed, we will work on updates to these files. ZOS_Software_List.json remains as a generic place to put any software that doesn't neatly fit into another category, but I have removed all tools related to the z/OS Open Tools project, since it's very outdated and there's another effort in progress to complete adding these tools into their own source file (see: openmainframeproject/software-discovery-tool#124). Signed-off-by: Elizabeth K. Joseph <lyz@princessleia.com>
pleia2
added a commit
to openmainframeproject/software-discovery-tool-data
that referenced
this pull request
Mar 28, 2024
In issue #49 a case was made that we have several sources for open source software being developed for IBM z/OS and it now makes sense to split up the repositories for easier maintenance and improved accuracy. This commit splits out the following: - Rocket Software into ZOS_Rocket_Software.json - Everything from github.com/IBM/IBM-Z-zOS/ into IBM_Z_zOS.json - Everything maintained by the Open Mainframe Project into ZOS_OMP.json Once this split is completed, we will work on updates to these files. ZOS_Software_List.json remains as a generic place to put any software that doesn't neatly fit into another category, but I have removed all tools related to the z/OS Open Tools project, since it's very outdated and there's another effort in progress to complete adding these tools into their own source file (see: openmainframeproject/software-discovery-tool#124). Signed-off-by: Elizabeth K. Joseph <lyz@princessleia.com>
pleia2
added a commit
to openmainframeproject/software-discovery-tool-data
that referenced
this pull request
Mar 28, 2024
In issue #49 a case was made that we have several sources for open source software being developed for IBM z/OS and it now makes sense to split up the repositories for easier maintenance and improved accuracy. This commit splits out the following: - Rocket Software into ZOS_Rocket_Software.json - Everything from github.com/IBM/IBM-Z-zOS/ into IBM_Z_zOS.json - Everything maintained by the Open Mainframe Project into ZOS_OMP.json Once this split is completed, we will work on updates to these files. ZOS_Software_List.json remains as a generic place to put any software that doesn't neatly fit into another category, but I have removed all tools related to the z/OS Open Tools project, since it's very outdated and there's another effort in progress to complete adding these tools into their own source file (see: openmainframeproject/software-discovery-tool#124). Signed-off-by: Elizabeth K. Joseph <lyz@princessleia.com>
pleia2
added a commit
to openmainframeproject/software-discovery-tool-data
that referenced
this pull request
Mar 28, 2024
In issue #49 a case was made that we have several sources for open source software being developed for IBM z/OS and it now makes sense to split up the repositories for easier maintenance and improved accuracy. This commit splits out the following: - Rocket Software into ZOS_Rocket_Software.json - Everything from github.com/IBM/IBM-Z-zOS/ into IBM_Z_zOS.json - Everything maintained by the Open Mainframe Project into ZOS_OMP.json Once this split is completed, we will work on updates to these files. ZOS_Software_List.json remains as a generic place to put any software that doesn't neatly fit into another category, but I have removed all tools related to the z/OS Open Tools project, since it's very outdated and there's another effort in progress to complete adding these tools into their own source file (see: openmainframeproject/software-discovery-tool#124). Signed-off-by: Elizabeth K. Joseph <lyz@princessleia.com>
pleia2
added a commit
to openmainframeproject/software-discovery-tool-data
that referenced
this pull request
Mar 28, 2024
* Split out z/OS package data In issue #49 a case was made that we have several sources for open source software being developed for IBM z/OS and it now makes sense to split up the repositories for easier maintenance and improved accuracy. This commit splits out the following: - Rocket Software into ZOS_Rocket_Software.json - Everything from github.com/IBM/IBM-Z-zOS/ into IBM_Z_zOS.json - Everything maintained by the Open Mainframe Project into ZOS_OMP.json Once this split is completed, we will work on updates to these files. ZOS_Software_List.json remains as a generic place to put any software that doesn't neatly fit into another category, but I have removed all tools related to the z/OS Open Tools project, since it's very outdated and there's another effort in progress to complete adding these tools into their own source file (see: openmainframeproject/software-discovery-tool#124). Signed-off-by: Elizabeth K. Joseph <lyz@princessleia.com>
|
I have made the changes as requested in this PR. Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to add packages compatible with z/OS in response to issue #110. @arshPratap @pleia2 please take a look.