Changes to allow output to be a gzip file #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
|
please target "release-5.0.1" branch first |
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Restored try clause. Increased GZIP buffer size for effciency and for CryptoCards that only get used if buffer > = 8192 bytes Set GZIP flush option to prevent corruption of file on last write Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
|
Updated code as suggested. Added buffer=8192 and syncflush parms to open of gzip file, so last record is written , and file is not corrupt. |
alexgubanow
reviewed
Mar 27, 2024
| @@ -95,15 +99,23 @@ else if (outputFileName == null) | |||
| printUsageAndExit(); | |||
| } | |||
|
|
|||
| System.out.println("Attempting to decompress input file (" + inputFileName +") to output file (" + outputFileName +")"); | |||
|
|
|||
There was a problem hiding this comment.
code below has duplicate lines, which may lead to errors later. more cleaner solution would be to create an object of FileOutputStream, while GZIPOutputStream is overload of such.
Suggested change
| var outputStream = null; | |
| try { | |
| if (outputFileName.endsWith(".gz")) { | |
| outputStream = new GZIPOutputStream(new FileOutputStream(outputFileName), 8192, true); | |
| } | |
| else { | |
| outputStream = new FileOutputStream(outputFileName); | |
| } | |
| } | |
| try (TerseDecompresser outputWriter = TerseDecompresser.create(new FileInputStream(inputFileName), outputStream )) | |
| { | |
| outputWriter.TextFlag = textMode; | |
| outputWriter.decode(); | |
| } |
suggested code is just to describe the idea, please test it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to allow output to be a gzip file (if the filename ends with ".gz")