15 can you please add support to decompress to zipoutputstream #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Restored try clause. Increased GZIP buffer size for effciency and for CryptoCards that only get used if buffer > = 8192 bytes Set GZIP flush option to prevent corruption of file on last write Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Rebased upon existing 5.0.1 branch Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Rebased upon existing 5.0.1 branch Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Rebased change using existing 5.0.1 branch Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Rebased upon existing 5.0.1 branch Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Rebased using existing 5.0.1 branch Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Rebased using existing 5.0.1 branch. Note this change bumps java to Java 17, and uses Shade to reduce output size Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
trivial indentation fix Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Restored maven jar plug-in Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
Signed-off-by: Russell Shaw <69813534+kiwi1969@users.noreply.github.com>
alexgubanow
requested changes
Mar 29, 2024
| @@ -0,0 +1,15 @@ | |||
| # Declares that this is the top-level configuration | |||
There was a problem hiding this comment.
please add .editorconfig to .gitignore too, as it is per developer to setup own
|
|
||
| if (args.length == 0) | ||
| parseArgs(args); | ||
| if (args.length == 0 || (inputFileName == null && outputFileName == null) || (outputFileName == null && textMode == false) || isHelpRequested == true) |
There was a problem hiding this comment.
CAN BE IGNORED - check for isHelpRequested right after args.length, reasons:
- faster in case of isHelpRequested
- simpler to read code, as it first check simple things, later more complicated
| else if (inputFileName == null) { | ||
| inputFileName = args[i]; | ||
| } | ||
| // second non-flag argument is the input file name |
There was a problem hiding this comment.
looks like typo, should it be "second non-flag argument is the output file name" ?
| } | ||
| else // we have more args than we know what to do with | ||
| { | ||
| isHelpRequested = true; |
There was a problem hiding this comment.
lets call break here, as there is no point to run more this loop
| @@ -95,18 +103,49 @@ else if (outputFileName == null) | |||
| printUsageAndExit(); | |||
| } | |||
|
|
|||
| System.out.println("Attempting to decompress input file (" + inputFileName +") to output file (" + outputFileName +")"); | |||
There was a problem hiding this comment.
Here is an example how it will be more streamlined:
Suggested change
| System.out.println("Attempting to decompress input file (" + inputFileName +") to output file (" + outputFileName +")"); | |
| System.out.println("Opening output file (" + outputFileName + ")"); | |
| var outputStream = null; | |
| try { | |
| if (outputFileName.endsWith(".gz")) { | |
| outputStream = new GZIPOutputStream(new FileOutputStream(outputFileName), 8192, true); | |
| } | |
| else { | |
| outputStream = new FileOutputStream(outputFileName); | |
| } | |
| } | |
| catch (Exception e) { | |
| System.out.println("Got exception while opening output file (" + outputFileName + ").\nError message:\n" + e.toString()); | |
| } | |
| System.out.println("Attempting to decompress input file (" + inputFileName + ") to output file (" + outputFileName + ")"); | |
| try (TerseDecompresser outputWriter = TerseDecompresser.create(new FileInputStream(inputFileName), outputStream)) { | |
| outputWriter.TextFlag = textMode; | |
| outputWriter.decode(); | |
| } | |
| catch (Exception e) { | |
| System.out.println("Got exception while decompressing input file (" + inputFileName + ").\nError message:\n" + e.toString()); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for gzip output file.
To do this, simple add ".gz" onto end of output file