-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Licensei #696
base: main
Are you sure you want to change the base?
feat: add Licensei #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please take a look at the failing tests?
@csatib02 Please check the failing test, then break it into two commits, so it's easier to review: 1. configs, readme, etc 2. license headers |
94ea8ff
to
cc1bd18
Compare
I looked into the flaky e2e-tests, and it is most probably linked to the timing of the events created.
The reason why it fails sometimes:
I can come up with a solution for this in a follow up PR if you want me to do so. 😀 |
Can you please rebase? |
11dfbbb
to
c2fdb7d
Compare
@sagikazarmark Done. |
4d1604a
to
e664444
Compare
feat: Add makefile target for deps, add licensei Signed-off-by: Bence Csati <bcsati@cisco.com> feat: add ignored imports Signed-off-by: Bence Csati <bcsati@cisco.com> feat: add isc and mpl-2.0 as approved licenses Signed-off-by: Bence Csati <bcsati@cisco.com> feat: add more to ignored Signed-off-by: Bence Csati <bcsati@cisco.com> feat: add more to ignored Signed-off-by: Bence Csati <bcsati@cisco.com> chore: add call for print-target Signed-off-by: Bence Csati <bcsati@cisco.com> chore: update readme Signed-off-by: Bence Csati <bcsati@cisco.com> Signed-off-by: Bence Csati <bcsati@cisco.com> chore: Add missing license ignores
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
e664444
to
3d22d80
Compare
Overview
makefile
target for project dependencies.Namely:
Licensei
to the CI.readme
.Fixes #22
Notes for reviewer
github.com/couchbase/goprotostellar
.Checklist