Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONOTMERGE: add static reset command to have a ripple effect with a static low light #1758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicman23
Copy link

Mostly a pull request to see if anyone else is interested to work with me on this because i have a green only blackwidow.

as a result the commit assumes my set up and has a hard coded self.low_colour and also a bumped refresh because it was a bit slow for my liking.

@nicman23
Copy link
Author

demo: https://imgur.com/a/iQjMFIB

@micwallace
Copy link

Hey @nicman23,

I've just tested this on my RGB keyboard and it works well. If I have some spare time I'll look at updating the code further so the color can be selected from Polychromatic.

@nicman23
Copy link
Author

great ! what i am not sure after thinking about it is if the static_reset function should be on the ripple effect file or in the same place that reset_rows is

@micwallace
Copy link

micwallace commented Feb 23, 2022 via email

@github-actions github-actions bot added the Stale label Aug 9, 2022
@github-actions github-actions bot closed this Aug 16, 2022
@z3ntu z3ntu reopened this Aug 16, 2022
@z3ntu z3ntu removed the Stale label Aug 16, 2022
@nicman23
Copy link
Author

is there any interest on this? i d like to mainstream it

@Dixbee
Copy link

Dixbee commented Dec 1, 2022

Thanks for this! Not having a static "background" color on effects like ripple and reactive has been my biggest issue with my setup, so I would love to see this added. For now, I've copied your changes and will play around to see what I can tweak for myself.

@marci-nlm
Copy link

Hi. Was this ever addressed? I have multiple color keyboard (BlackWidow V3) and I'm looking at this code to implement this for the ripple effect. I feel like it'd be a great addition. If not for the main project at least as some sort of external script

@marci-nlm
Copy link

marci-nlm commented Jul 20, 2023

Hi. Was this ever addressed? I have multiple color keyboard (BlackWidow V3) and I'm looking at this code to implement this for the ripple effect. I feel like it'd be a great addition. If not for the main project at least as some sort of external script

I have addressed the multiple color issue with this code.
https://github.com/openrazer/openrazer/compare/master...andromedarion:openrazer:static-ripple?expand=1\

Works well with Polychromatic, didn't test anything else.

Admittedly, I barely read through the code and it's quite possible this requires a lot more work to ensure it does not break things, but it's good enough for me.
Thanks @nicman23 , for providing the basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants